Coder Social home page Coder Social logo

Comments (10)

sindresorhus avatar sindresorhus commented on May 8, 2024 2

Alright. Let's do it then.

from eslint-plugin-unicorn.

sindresorhus avatar sindresorhus commented on May 8, 2024 1

Yeah. Doesn't have to happen often to be useful.

Might want to wait on this though (from linked issue):

I'll leave this open for a bit to see if anyone on the team wants to disagree.

from eslint-plugin-unicorn.

jfmengels avatar jfmengels commented on May 8, 2024 1

Closing as it's being integrated in ESLint core rules eslint/eslint#6767

from eslint-plugin-unicorn.

ljharb avatar ljharb commented on May 8, 2024

It's now closed, sadly. I'd love to be able to use this rule.

from eslint-plugin-unicorn.

ljharb avatar ljharb commented on May 8, 2024

@sindresorhus it'd be awesome if it could be done standalone, and made a dep of this one, so i can use it in other packages without having to bring in this entire package :-)

from eslint-plugin-unicorn.

jfmengels avatar jfmengels commented on May 8, 2024

You wouldn't get much less by having a standalone module (there a not a lot of dependencies... yet), and maybe you'll want all the awesome rules that it has and will have? :D

More seriously, to me, it's a bit of a pain to create a new project for it. I agree that you might not want all the rest, but maintaining-wise, it's simpler to have it in a project that is actively maintained by several people, not in a corner somewhere. I proposed to add it here because this is a collection of various rules, and what you asked for is kind of a specific rule, with no existing plugin (afaik) it could get included in.

Then again, if we write this rule, you're free to copy it in a new repo and use it as you see fit.

from eslint-plugin-unicorn.

ljharb avatar ljharb commented on May 8, 2024

I use eslint-find-rules --unused to ensure that all rules available are defined, so if I bring in a plugin with N rules, i have to add N lines to my eslint config.

If the authors don't mind, then once written, I'd be happy to spend the few minutes required to create a new project, and would be happy to copy the code and share ownership/maintainership of it, especially if this module could pull it in as a dep.

from eslint-plugin-unicorn.

jamestalmage avatar jamestalmage commented on May 8, 2024

More seriously, to me, it's a bit of a pain to create a new project for it.

Maybe we should build this project as a monorepo? Split each rule into its own package? It would be interesting to explore what AVA and XO could do to enable monorepo development:

  • shared config
  • easily test/lint all submodules/packages
  • easily test/lint an individual submodule/package

from eslint-plugin-unicorn.

jfmengels avatar jfmengels commented on May 8, 2024

Maybe we should build this project as a monorepo

Can be interesting.

explore what AVA and XO could do to enable monorepo development

Does AVA already do something monorepo-like, or are you suggesting it could start doing something in that vein? If so, I'm curious as to what parts of it.

from eslint-plugin-unicorn.

sindresorhus avatar sindresorhus commented on May 8, 2024

I'm really not a big fan of monorepos. At this point it would seem like a premature complication. It would also add a lot of overhead. I think the rules we have now makes sense in one package. We currently have a nice setup with tests, docs and code coverage. I don't really see the problem depending on this plugin, even if you only want one rule. We currently only have 4 tiny dependencies. Dependencies matters less in a dev environment.

I use eslint-find-rules --unused to ensure that all rules available are defined, so if I bring in a plugin with N rules, i have to add N lines to my eslint config.

I would rather fix that module. It should have an ignore option.

from eslint-plugin-unicorn.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.