Comments (10)
Alright. Let's do it then.
from eslint-plugin-unicorn.
Yeah. Doesn't have to happen often to be useful.
Might want to wait on this though (from linked issue):
I'll leave this open for a bit to see if anyone on the team wants to disagree.
from eslint-plugin-unicorn.
Closing as it's being integrated in ESLint core rules eslint/eslint#6767
from eslint-plugin-unicorn.
It's now closed, sadly. I'd love to be able to use this rule.
from eslint-plugin-unicorn.
@sindresorhus it'd be awesome if it could be done standalone, and made a dep of this one, so i can use it in other packages without having to bring in this entire package :-)
from eslint-plugin-unicorn.
You wouldn't get much less by having a standalone module (there a not a lot of dependencies... yet), and maybe you'll want all the awesome rules that it has and will have? :D
More seriously, to me, it's a bit of a pain to create a new project for it. I agree that you might not want all the rest, but maintaining-wise, it's simpler to have it in a project that is actively maintained by several people, not in a corner somewhere. I proposed to add it here because this is a collection of various rules, and what you asked for is kind of a specific rule, with no existing plugin (afaik) it could get included in.
Then again, if we write this rule, you're free to copy it in a new repo and use it as you see fit.
from eslint-plugin-unicorn.
I use eslint-find-rules --unused
to ensure that all rules available are defined, so if I bring in a plugin with N rules, i have to add N lines to my eslint config.
If the authors don't mind, then once written, I'd be happy to spend the few minutes required to create a new project, and would be happy to copy the code and share ownership/maintainership of it, especially if this module could pull it in as a dep.
from eslint-plugin-unicorn.
More seriously, to me, it's a bit of a pain to create a new project for it.
Maybe we should build this project as a monorepo? Split each rule into its own package? It would be interesting to explore what AVA and XO could do to enable monorepo development:
- shared config
- easily test/lint all submodules/packages
- easily test/lint an individual submodule/package
from eslint-plugin-unicorn.
Maybe we should build this project as a monorepo
Can be interesting.
explore what AVA and XO could do to enable monorepo development
Does AVA already do something monorepo-like, or are you suggesting it could start doing something in that vein? If so, I'm curious as to what parts of it.
from eslint-plugin-unicorn.
I'm really not a big fan of monorepos. At this point it would seem like a premature complication. It would also add a lot of overhead. I think the rules we have now makes sense in one package. We currently have a nice setup with tests, docs and code coverage. I don't really see the problem depending on this plugin, even if you only want one rule. We currently only have 4 tiny dependencies. Dependencies matters less in a dev environment.
I use eslint-find-rules --unused to ensure that all rules available are defined, so if I bring in a plugin with N rules, i have to add N lines to my eslint config.
I would rather fix that module. It should have an ignore option.
from eslint-plugin-unicorn.
Related Issues (20)
- `prevent-abbreviations` - non-ASCII characters ignored in filenames HOT 1
- `prefer-node-protocol` should not flag non-node imports HOT 2
- `unicorn/no-array-callback-reference` does not report when optional chaining HOT 1
- Rule change proposal: `no-useless-undefined` add option to skip checking function body
- `prefer-spread` should not report on optional chaining HOT 1
- Override dont work when change only configuration HOT 2
- Reconsider `no-document-cookie` enabled by default HOT 7
- Missing rules in plugin HOT 1
- `multipleFileExtensions` in `unicorn/filename-case` is not working correctly with eslint flat config
- prefer-dom-node-dataset: bad fix for playwright
- Rule proposal: `.replace` or `.replaceAll` with non-literal replacement HOT 3
- filename-case: pascalCase should allow stuff like FAQPage.js
- Don't prefer number properties for Infinity by default HOT 5
- Fix for '/|/g can be optimized to //g' in the better-regex rule breaks regular expression syntax
- `prefer-number-properties` changes HOT 1
- Rule proposal: `require-css-escape` HOT 1
- support calver in package.json error HOT 1
- Check `throw Object.assign(Error('...'), ...)` in `throw-new-error`
- Documentation `prefer-string-slice` HOT 3
- missing TypeScript declaration file HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eslint-plugin-unicorn.