Coder Social home page Coder Social logo

Discriminated union about typebox HOT 2 CLOSED

thibauds avatar thibauds commented on June 11, 2024
Discriminated union

from typebox.

Comments (2)

sinclairzx81 avatar sinclairzx81 commented on June 11, 2024

@thibauds Hi,

Unfortunately, this is a known limitation with TS enums. The problem is that TypeScript treats enum values as opaque, meaning they're invisible to the type system. Because they're invisible to the type system, they are also invisible to TypeBox (which is why you're seeing any inferred).

There's been a few attempts to try an get constant values from TS enums in the past, unfortunately each attempt has lead to type scalability issues (and very slow inference performance for large enums). Because of this, using enum discriminators is generally not recommended (for now)

This said, you can get around this issue by not using enums, and instead using string literal values. These are observable to TypeBox, and generally are a better way to represent as discriminator properties (as they're directly encodable in Json Schema and don't require auxiliary knowledge of the enum data structure)

Workbench Link Here

type Moving = {
  id: string
  disc: 'user' | 'poney'
}
type Inert = {
  disc: 'rock'
}
export type Item = {
  name: string
} & (Moving | Inert)

As a general rule of thumb, Enum are usually more useful for representing options, and less so for discriminator properties. For discriminators, always preference literal values if possible.

Hope this helps
S

from typebox.

thibauds avatar thibauds commented on June 11, 2024

Thank you for this detailed answer 🙏

from typebox.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.