Counter column values not returning as integers about helenus

[devdazed]

it looks like the driver didn't know how to decode the response properly, which version of C* are you running? is this using CQL 3 or CQL 2?

[calvinfo]

Whoops, didn't check for CQL support when testing counters.

The problem seems to come from the fact that thrift returns the counter value as a plain long whereas CQL returns it as a buffer which needs deserialization. I'm not sure why this is exactly.

The simplest fix I see is to set the CounterColumn deserializer to be Deserializers.decodeLong (fixes CQL) and then add a special case for counters from Row.fromThrift() to fix the thrift client.

What are your thoughts @devdazed ?

[devdazed]

I think this is the best course of action for now, change the CounterColumn deserializer from IDENTITY to Deserializers.decodeLong and then we can fix the thrift client to check if it is a counter column and ignore deserialization.

[calvinfo]

I made the changes we discussed, should be fixed now. Let me know if there's any tests that I missed.

[jamesbloomer]

Working great now, thanks.