Embedded videos don't work about privacy-redirect

[SimonBrazell]

New version (v1.1.3) that includes that change is pending review on the stores. Please let me know if you encounter any issues with it.

[SimonBrazell]

Found the problem, I misinterpreted the way that the browser.webRequest.onBeforeRequest.addListener() filters worked.

Because I am only listening for requests from specific domains (twitter.com, youtube.com, etc.) I am missing any requests from iframes that are embedded within another site as they originate from whichever site they are embedded in and so aren't matched by my filters. Even though the request is for a domain in my filters list it's originUrl is something else and it is this field that the filters are matched on (well either originUrl or documentUrl).

So it appears in order to resolve this issue I do indeed have to listen for <all_urls>, bit of a bummer, doesn't seem to be any way around it.

[Jpxe]

It works for me now, thanks a lot!

[SimonBrazell]

Hello @funnyflowerpot!

Thanks for the feedback and code examples, I'll see what I can put together, this plugin is still pretty basic, I'll put some more time into working out this issue.

Do you happen to have the URL of the original page that includes the broken embedded videos that I can use for troubleshooting and testing the fix? I'm sure I can find one myself but I want to make sure I'm addressing the specific issue you are experiencing.

[Jpxe]

I have the same issue, example on: https://www.reddit.com/r/videos/

[funnyflowerpot]

Hey @SimonBrazell, thanks for the response.

I rechecked and I believe this applies to any embedded video. I confirm the example by @ToughGuyKunio. You can seem to pick any video, like this or this (click on "Get started") for example.

[SimonBrazell]

@funnyflowerpot looks to be specific to Firefox, I just visited the link supplied by @ToughGuyKunio above using Ungoogled Chromium and the embedded videos load, although not all, some display this message - The media could not be loaded, either because the server or network failed or because the format is not supported.

I'm still not sure what the root cause of this issue is yet, I tried using the code in the repo you supplied but the issue was still present on Firefox.

[Jpxe]

I tried this Invidious Redirect extension fork (code). I use Firefox 72 on Manjaro Linux. All embedded videos works (except those that don't work on main invidio.us site). If it helps.

[SimonBrazell]

Thanks @ToughGuyKunio, I tried a few variations on that code you posted just now to no avail, might need to spend some more time on this to figure it out. One difference I can see is that the background script on the other repo listens for requests from all urls and only for main_frame and sub_frame types while this extension listens for only targeted domains and more types so perhaps there is something in that...

[SimonBrazell]

Okay so it seems I can fix this by listening for "<all_urls>" instead of the current targeted list:

"*://twitter.com/*", "*://www.twitter.com/*", "*://mobile.twitter.com/*", "*://youtube.com/*", "*://www.youtube.com/*", "*://youtube-nocookie.com/*", "*://www.youtube-nocookie.com/*", "*://m.youtube.com/"

And limiting the request types to "main_frame", "sub_frame" instead of:

"main_frame", "sub_frame", "stylesheet", "script", "image", "object", "xmlhttprequest", "other".

But one of the aims I had with this extension was to do it with minimal permissions, giving the extension access to all URLs seems like overkill, maybe I should keep looking...

[SimonBrazell]

Glad to hear, lets hope that it gets approved on the Chrome store now, changing the permissions means it has to go through the review process... still waiting for it to be reviewed.

[funnyflowerpot]

Thanks a lot @SimonBrazell for the quick responses! Works for me, too!

[SimonBrazell]

No worries, just noticed the update went live on the Chrome store today also.