Comments (3)
I experienced that they
- block movement of teammates (monsters walk around invisible dying guys)
- can be made visible by aiming manually
- may even try to flee (or at least I had that feeling)
- make attacks of opportunity.
In case of attacks of opportunity I think problem lies here:
ovr014.cs, line 363:
if (attacker.actions.delay > 0 ||
attacker.actions.field_F == 0 ||
ovr032.CanSeeCombatant(var_1B % 8,
ovr033.PlayerMapPos(player), ovr033.PlayerMapPos(attacker)) == true)
actions.field_F is related to backstabbing. Actually, it is the number of times
the
attacker has been target for a physical (melee?) attack. Hence, it can be
called like
attacks_received.
It does make sense to check it here, since those that cannot turn possibly
cannot
make attacks of opportunity against those they cannot see, but magical attacks
do not
increase this count, so the disjunctive condition is fulfilled (unless it
received an
attack earlier that round).
Fixing this would only be a partial workaround though.
Original comment by surrano
on 18 Sep 2009 at 7:00
from coab.
The difference between phys and magic attacks is:
ovr014.DisplayAttackMessage:
if (target.in_combat == false)
{
...
ovr024.RemoveCombatAffects(target);
ovr024.CheckAffectsEffect(target, CheckType.Death);
if (target.in_combat == false)
{
ovr033.CombatantKilled(target);
}
else
{
seg041.GameDelay();
}
}
ovr024.damage_person:
if (player.in_combat == false)
{
...
if (gbl.game_state == GameState.Combat)
{
seg041.GameDelay();
}
else
{
RemoveCombatAffects(player);
CheckAffectsEffect(player, CheckType.Death);
if (player.in_combat == false)
{
ovr033.CombatantKilled(player);
}
else
{
seg041.GameDelay();
}
}
}
Changing the GameState check to notequal:
if (gbl.game_state != GameState.Combat)
fixes the problem, but I don't know whether it introduces some side effects
during
adventuring. I think no; it should be the original way. Could you please
cross-check
in asm code.
Another question: may in_combat change to TRUE, once changed to FALSE? Esp.
within
RemoveCombatAffects or CheckAffectsEffect? If no then the internal if check is
unnecessary and the GameDelay will never be called. Just a thought... maybe
there is
some hacking around, e.g. in case of Boars, Trolls, etc... whoever gets up after
having been downed.
Original comment by surrano
on 18 Sep 2009 at 7:15
from coab.
Wow, such a simple fix, and I'd not followed it up, thanks for finding the
cause of
the issue.
I've not tested it, but you correct the I had the test flipped, so I'll believe
your
testing.
Your also correct that CheckAffectsEffect(player, CheckType.Death) does the
death
check for trolls. Now I'm sure that method doesn't do the revive logic, but it
doesn't seem to do any harm leaving the code there for now.
Original comment by simeon.pilgrim
on 5 May 2010 at 5:23
- Changed state: Fixed
from coab.
Related Issues (20)
- Crash using secret door in sewers HOT 2
- Unreadying "Ring Of Wizardry" causes a crash HOT 1
- Drow's treasure seems wrong HOT 1
- Dark Elf Lord encounter seems missing HOT 1
- Party summary views shows AC as --3 HOT 1
- Crash Dropping Coins HOT 2
- Crash get pooled coins HOT 1
- Crash during combat
- Crash during combat with Shambling mounds in Yulash HOT 1
- Mulmaster Corps attacks pass through walls HOT 1
- Arrow numbers in combat don't display correctly
- Combat sounds sometime wrong?
- How did you do this? HOT 2
- Why add 1 to stats? HOT 6
- What's going on with these cryptic arrays? HOT 5
- No import supported from CopyCurse.exe HOT 1
- License of coab
- how do i run this in full screen. HOT 4
- 0/0
- Compile
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from coab.