Comments (6)
One solution, which is probably the easiest solution, is we just copy the abandoned repository into a new /thirdparty folder in this repo. Looking at the LICENSE.md, I don't see any reason not to. @maxime-rainville what do you think?
from silverstripe-akismet.
Looking at tijsverkoyen/Akismet, it's a pretty small packages.
We've used the "thirdparty folder" approach in the past for dependencies that had never been shipped in a composer package and usually didn't have any namespace and were contain in a single file. I don't think that's the best solution here.
I would suggest those possible solutions:
- Remove dependency on
tijsverkoyen/akismet
, duplicate all the classes into our own namepsace, and update all references to use our own classes. - Copy
tijsverkoyen/akismet
into this module, add a PSR4-autoloading entry for it to our composer file and aprovide
statement. Maybe add a warning to say ... those classes are in the module but we don't consider them part of our API.
In theory, we could fork tijsverkoyen/akismet
but I don't want to be stuck maintaining the library for non-Silverstripe-CMS projects.
from silverstripe-akismet.
Might be worth pointing out that there's noting blocking the installation of an archived packages ... although it's not a great look when you start a new project and you see a bunch of warnings that you are using unmaintained libraries.
from silverstripe-akismet.
I'm not really too concerned that is abandoned. It's not been updated in ~6 years and it never concerned anyone, so the fact it's just formally abandoned now isn't a big deal.
If we think it's a really big deal we can implement our own API interaction, because that module code needs a bit of modernisation
from silverstripe-akismet.
The problem is that tijsverkoyen/akismet
is on our list of supported dependencies. So we have committed to look after it which puts us into a somewhat awkward situation.
Adding it there was probably a bit dumb. What we should care about is silverstripe/akismet
, not any underlying library it might uses.
from silverstripe-akismet.
Hmm, indeed - hard to claim to support a library we have no rights to.
Looks like the list needs updating and possibly the API logic just re-written for our module
from silverstripe-akismet.
Related Issues (6)
- TODO: Integrate with upstream ham/spam notifications
- Holder: SS4 compatibility HOT 2
- Check and update module for SS4 compatibility where necessary HOT 1
- Akismet module loads and performs a full table scan on every request (for no reason) HOT 3
- tijsverkoyen/akismet constraint is too strict and might not work on PHP8 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from silverstripe-akismet.