Cookie handler does not support 'expires' on split cookie function about cordova-plugin-advanced-http

[mburger81]

Hi @silkimen we test the plugin only on android emulator for now using a Nexus 5 KitKat device. We didn't test it on ios or devices.
But I'm pretty sure it has the the same error.

The cookie handler on splitfunction supports only lowercase. But the 3rd part server returns Expires part for the cookie with upper E. So I don't think the device type is changing the behavior
I think you should check wor case insensitive or?

[silkimen]

Yes, basically you are right. But I think we should normalize all header keys e.g. having them all in lower-case. So even if the server responds with "Expires", "EXPIRES" or "expires", we should access it with key "expires". I thought we are already doing that, but seems to be broken somehow. That's the reason I'm asking for the device on which this problem occurs.

But I'll implement a workaround for now to fix your problem.

Update: I was wrong, the "expires" string is not a header key, but part of the value. It's not a problem of normalized header keys. Bug is fixed in version 1.5.7.

[mburger81]

Hi thx, for the fast release this is working great!!!

You are right it is better testing for lower case, the reason I didn't do this in my PR is:
On testing for Expires= || expires= || EXPIRES= you have less probabilty to have some problems with for example a token which could be 'eXpireS='
But I think this should be not often a problem ;)