Comments (5)
gerar2
commented on May 9, 2024
1
This was working properly for us and stop working recently. It must be some recent commit
from ecs-deploy.
mirague
commented on May 9, 2024
Any idea what could have "undone" this improvement @fillup ?
from ecs-deploy.
mirague
commented on May 9, 2024
We found that taskRoleArn isn't even returned in the aws ecs describe-task-definition command. It's supposed to, according to the docs. Reached out to Amazon, will update once I know more.
Update: This particular bug was caused by having an old version of awscli (1.10). Upgrading to 1.11 solved this issue.
from ecs-deploy.
mirague
commented on May 9, 2024
Alright, solved this issue and opened up a PR (#76). @gerar2 @fillup
Somehow the returned old definition was filtered out and reconstructed before the logic of including the taskRoleArn was even included. I believe this filter was placed back/never removed by accident.
This can be closed when the PR is merged.
from ecs-deploy.
fillup
commented on May 9, 2024
PR #76 merged in
from ecs-deploy.
Related Issues (20)
- --aws-instance-profile is not yet in use HOT 2
- Unknown parameter in input: "registeredAt" HOT 1
- [Help needed] Exit status code 255 HOT 2
- Support for ECS deployment circuit breaker
- Update service not triggering HOT 1
- Support for canary releases with EXTERNAL deployments HOT 2
- BUG: copy-task-definition-tags error when task def has no tags HOT 6
- Won't able to switch image in container within task definition HOT 1
- Deployment takes a tonne load of time to complete now HOT 2
- reset proxyConfiguration after deployment HOT 4
- Doesn't actually update the image HOT 2
- Force new deployment using latest task definition
- running in github actions HOT 2
- [Feature request] Use same taskdef for multiple deployments
- ecs-deploy is not waiting for deployment to succeed HOT 11
- done update image other repo
- taskIds can have at most 100 items. HOT 2
- Run task Github actions input not used HOT 2
- Missing gha input for wait-for-success HOT 1
- ERROR: was unable to place a task. Reason: Capacity is unavailable at this time. Please try again later or in a different availability zone HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ecs-deploy.