Coder Social home page Coder Social logo

Inconsistent type for port field about node-consul HOT 2 CLOSED

silas avatar silas commented on September 13, 2024 1
Inconsistent type for port field

from node-consul.

Comments (2)

silas avatar silas commented on September 13, 2024

If you send a number to consul options it should work fine assuming you're not sending 0, does that not work? What do you suggest changing, just setting the || '8500' to a number of something?

from node-consul.

TobyColeman avatar TobyColeman commented on September 13, 2024

Sorry, I should have probably clarified that this is more an issue when using this library with Typescript:

import * as Consul from 'consul'

const myConsul: Consul = new Consul({ port: '8500' })
myConsul.agent.service.register({ name: 'redis', port: 8500 })

Of course, passing either a number or string is fine if you're just using JS :).

I suggest maybe just updating the docs to clarify that port should be a number in both cases, and perhaps make the default port a number like you said?

from node-consul.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.