Comments (5)
In order to implement this, we may need to use a config file (which is probably fine since we may want to add extra config options in the future anyway). One question: is rustfmt used within IRust itself (i.e. to format the user’s REPL code)? Reason I ask is because we shouldn’t need to check for it if it’s only used when we format IRust’s code, but I don’t know if IRust itself uses it.
Also, @sigmaSd your link to cargo-edit doesn’t go to the cargo-edit page for me ATM.
from irust.
We can as you suggested add an option "show optional dependencies warning" = false
, to do that we need to modify 2 places ( I think):
1 - add the option to Options struct https://github.com/sigmaSd/IRust/blob/master/src/irust/options.rs#L8
2 - parse it with the Options parser https://github.com/sigmaSd/IRust/blob/master/src/irust/options/parser.rs
3 - check for the option at start https://github.com/sigmaSd/IRust/blob/master/src/irust.rs#L90 and respond correctly
4 - at exit make the option true
(that's more than 2 I guess)
from irust.
@smolck we already have a configuration file! (just read the README :P )
Yes cargo fmt is used to beautify the code outputed with :show
will edit the link, good catch!
from irust.
@smolck we already have a configuration file! (just read the README :P )
I really should check these things
Now that I know that, I think we just need to insert a check (in main.rs or such) for a certain option in the config file that lets us know if we’ve shown the warning (it doesn’t necessarily need to be a new option: just one that wouldn’t be there at first, but that would appear after the first time starting IRust). If the option isn’t there, show the warning: if it is there, don’t.
from irust.
Fixed in 8e43fdb
from irust.
Related Issues (20)
- Add :cargo command
- Add predefined themes
- Rework how irust server works
- Use `rustyline` or `reedline` for input? HOT 1
- Move theme settings from config.toml to themes config
- Improve Jupyter kernel support HOT 7
- typing twice in windows with crossterm-0.26+ HOT 2
- Can irust repl evaluate code with release mode instead of debug mode? HOT 3
- Cannot use two `irust_repl`s at the same time. HOT 27
- Rust analyzer is not working on Windows HOT 6
- Interactive usage HOT 3
- Check statements with cargo check HOT 1
- how make irust works with nightly ? error: toolchain 'stable-x86_64-unknown-linux-gnu' is not installed HOT 2
- Using IRust for live scripting of a host HOT 8
- Custom keybindings? HOT 15
- [Feature Request]: Support for `proc_macro` APIs HOT 7
- [Feature Request]: Ability to load custom `Cargo.toml` HOT 2
- Async repl not working properly HOT 5
- irust v1.50.0 failed to compile HOT 2
- Use `rust-analyser` instead of `racer` for autocompletion HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from irust.