Coder Social home page Coder Social logo

Comments (9)

sidorares avatar sidorares commented on August 25, 2024

It's a command in mysql protocol and I really don't want to implement it. You can always change database with sql query: query('use someNewDb', cb). I don't mind to have changeUser as a wrapper to query - would it solve your problem? Do you want to create PR with this change?

from node-mysql2.

seanmonstar avatar seanmonstar commented on August 25, 2024

I wouldn't worry how it's actually implemented, wrapper or protocol. I was just trying to drop in mysql2 to compare the speeds in our test framework, and hit this error :)

from node-mysql2.

sidorares avatar sidorares commented on August 25, 2024

I agree that if I advertise it to be drop in replacement I need to add changeUser. Will do as a wrapper :)

from node-mysql2.

doug65536 avatar doug65536 commented on August 25, 2024

I believe changeUser is also used to reset a connection fully before returning it to a pool (ends all transactions, etc.) Does the connection pooling functionality already do that?

from node-mysql2.

sidorares avatar sidorares commented on August 25, 2024

@doug65536 No, not for node-mysql2 currently. Might be not a good idea in some cases (I don't want to loose all prepared statements when I return connection to pool)

from node-mysql2.

sidorares avatar sidorares commented on August 25, 2024

next in my queue. link to protocol doco: http://dev.mysql.com/doc/internals/en/com-change-user.html

from node-mysql2.

sidorares avatar sidorares commented on August 25, 2024

also make sure that code from mysqljs/mysql#806 is backported

from node-mysql2.

sidorares avatar sidorares commented on August 25, 2024

and mysqljs/mysql@5e43c5c as well ( or better, pull all latest Pool / PoolCluster changes from node-mysql )

from node-mysql2.

sidorares avatar sidorares commented on August 25, 2024

landed, soon to be published as 0.15.0

from node-mysql2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.