Stored procedures in binary protocol about node-mysql2

[brandonramirez]

I suspect this is the same issue, so posting here instead of a new issue. If it turns out to be unrelated, we can open a new issue.

I get "TypeError: object is not a function" when calling a stored procedure via a prepared statement. It works if I replace .execute with .query.

Stack trace:

  var r = new this.statementInfo.parser(packet);
          ^
TypeError: object is not a function
    at Execute.row (/Users/brandon/Desktop/binder-test/node_modules/mysql2/lib/commands/execute.js:181:11)
    at Execute.Command.execute (/Users/brandon/Desktop/binder-test/node_modules/mysql2/lib/commands/command.js:26:20)
    at Connection.handlePacket (/Users/brandon/Desktop/binder-test/node_modules/mysql2/lib/connection.js:263:28)
    at PacketParser.onPacket (/Users/brandon/Desktop/binder-test/node_modules/mysql2/lib/connection.js:68:65)
    at PacketParser.execute (/Users/brandon/Desktop/binder-test/node_modules/mysql2/lib/packet_parser.js:37:14)
    at Socket.<anonymous> (/Users/brandon/Desktop/binder-test/node_modules/mysql2/lib/connection.js:80:31)
    at Socket.emit (events.js:95:17)
    at Socket.<anonymous> (_stream_readable.js:748:14)
    at Socket.emit (events.js:92:17)
    at emitReadable_ (_stream_readable.js:410:10)

Sample code:

var mysql = require('mysql2');

var connection = mysql.createConnection({
  host: '10.0.1.44',
  user: 'root',
  database: 'mytestdb'
});

connection.execute('CALL get_user(?)', [ 1 ], function (err, rows) {
  console.log(JSON.stringify(rows, null, 2));
  connection.end();
});

[sidorares]

@brandonramirez thanks for report. This was low priority for me ( you can switch to text protocol if you really need multiple statements ). I might give it some attention, but it requires some code restructuring

Can you make minimal case (including code to create temporary procedure) so it's easier for me to replicate?

[sidorares]

nevermind, I actually have example in issue body (but still feel free to include your if my example gives different result to you)

[brandonramirez]

This is the source for the get_user procedure being called by the previously given client code.

CREATE PROCEDURE `get_user`(IN supplied_user_id INT)
  BEGIN
    select * from user_account ua where ua.user_id = supplied_user_id;
  END

[sidorares]

should be (partially) fixed. Your example might still not work as it requires multiple statement support (select + procedure result itself). I'll address this in execute() refactor as doing directly would add a lot of duplicated code between commands/query.js and commands/execute.js

[sidorares]

should be closed by #157