Comments (7)
Sounds good!
from bundlesize.
I am not working on this case yet, but I just wanted to discuss some test case scenarios and gets inputs from other also. This might be helpful for any other contributor who wants to work on it in future.
-
Best case scenario
When file name is short like:
./dist.js
In this case no truncation of text is needed.
-
2nd scenario
When file path is long like:
./lighthouse-extension/dist/scripts/lighthouse-background.js
In this case, I think we can truncate it to like
~/lighthouse-background.js
.
What do you think? -
3rd scenario
When file name is long (more than 35 chars) like:
./lighthouse-background-long-filename.js
In this case, I think we can truncate it to something like
~/light...name.js
.
What do you think?
What other test case scenarios we have?
from bundlesize.
I like all of those solutions!
I'd also like to add the case of multiple files in possibly different folders.
from bundlesize.
Another thing I'll throw into the mix is: should we do this in the CLI or on the store/details page.
Doing it in the CLI is a more effective use of URL length, but doing on the details page gives us the flexibility of deploying whenever we want even with breaking changes.
from bundlesize.
Whoops, we should this conversation to #81
from bundlesize.
You mean showing the path with it's parent directory, right?
Like
~/parent1/file1.js
~/parent2/file2.js
from bundlesize.
@vs1682 yep.
moved to #82
from bundlesize.
Related Issues (20)
- Absolute paths for config files don't work HOT 2
- Readme does not include CI env var
- Support for codesandbox HOT 12
- Support of Asset Map in addition to the Path Parameters to Define the list of Files HOT 4
- Assorted TODO
- Not working on GitHub Actions? HOT 14
- Leverage source-map-explorer when viewing details through Github
- Feature: Override wildcards with specific settings HOT 6
- Is it safe to publicize BUNDLESIZE_GITHUB_TOKEN ? HOT 9
- bundlesize-store.now.sh not working for private repos? HOT 2
- Details of security checks unavailable in Github pull requests HOT 1
- Feature: Support for Buddy CI HOT 5
- Could not add github status. 403: Resource not accessible by integration HOT 2
- Add Diff budgeting in addition to maxSize budget HOT 2
- Update axios dependency due to security vulnerability HOT 8
- Bundlesize 404 from googleapis/urlshortener
- Add support for node versions 12.x and above HOT 2
- Test for the sum of all chunks sizes HOT 1
- Does BundleSize is also generate report for Azuare Devops Pipeline HOT 1
- Bundle size throws and fails if a file at the path provided in config does not exist. No way to opt out of this
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bundlesize.