Coder Social home page Coder Social logo

Comments (7)

siddharthkp avatar siddharthkp commented on May 19, 2024

Sounds good!

from bundlesize.

palashmon avatar palashmon commented on May 19, 2024

I am not working on this case yet, but I just wanted to discuss some test case scenarios and gets inputs from other also. This might be helpful for any other contributor who wants to work on it in future.

  • Best case scenario

    When file name is short like:

    ./dist.js
    

    In this case no truncation of text is needed.

  • 2nd scenario

    When file path is long like:

    ./lighthouse-extension/dist/scripts/lighthouse-background.js
    

    In this case, I think we can truncate it to like ~/lighthouse-background.js.
    What do you think?

  • 3rd scenario

    When file name is long (more than 35 chars) like:

    ./lighthouse-background-long-filename.js
    

    In this case, I think we can truncate it to something like ~/light...name.js.
    What do you think?

What other test case scenarios we have?

from bundlesize.

siddharthkp avatar siddharthkp commented on May 19, 2024

I like all of those solutions!

I'd also like to add the case of multiple files in possibly different folders.

from bundlesize.

siddharthkp avatar siddharthkp commented on May 19, 2024

Another thing I'll throw into the mix is: should we do this in the CLI or on the store/details page.

Doing it in the CLI is a more effective use of URL length, but doing on the details page gives us the flexibility of deploying whenever we want even with breaking changes.

from bundlesize.

siddharthkp avatar siddharthkp commented on May 19, 2024

Whoops, we should this conversation to #81

from bundlesize.

vs1682 avatar vs1682 commented on May 19, 2024

You mean showing the path with it's parent directory, right?
Like
~/parent1/file1.js
~/parent2/file2.js

from bundlesize.

siddharthkp avatar siddharthkp commented on May 19, 2024

@vs1682 yep.

moved to #82

from bundlesize.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.