Coder Social home page Coder Social logo

Comments (8)

Warxcell avatar Warxcell commented on July 2, 2024 1

I would probably refactor DistanceCalculator and use instance of it instead static method.
Something like that:

$calculator = new DistanceCalculator($points);
$rawDistance = $calculator->getRawDistance();
$distanceWithAltitude = $calculator->getRealDistance()

Better ideas for method names?

from phpgpx.

Sibyx avatar Sibyx commented on July 2, 2024

Hi, nice idea. I am thinking of the implementation. If it's better to create a new attribute or create a configuration flag. What do you think?

Sorry for the later response, I was on holiday.

from phpgpx.

Warxcell avatar Warxcell commented on July 2, 2024

Well I guess it will be best if there is parallel property with calculated distance with included altitude. Right now in my project I'm using both of them. Distance with altitude to have real distance and Distance without altitude to calculate average grade between two points. :)

from phpgpx.

Sibyx avatar Sibyx commented on July 2, 2024

OK then :) Would you like to offer PR or I should do the implementation?

from phpgpx.

Sibyx avatar Sibyx commented on July 2, 2024

Hmm, sounds good to me. I am just not sure about changing API (I am not proud about the library versioning :D )

from phpgpx.

Warxcell avatar Warxcell commented on July 2, 2024

Well, isn't that DistanceCalculator for internal use only? If so, shouldn't be a problem.

from phpgpx.

Sibyx avatar Sibyx commented on July 2, 2024

Ahh I see, sorry. So then is not problem at all ;)

from phpgpx.

Sibyx avatar Sibyx commented on July 2, 2024

Implemented as realDistance property in Route, Segment, Stats, Track objects.

from phpgpx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.