Comments (9)
Which OS are you using ? I just checked in Linux (Fedora 20) and Windows 7. The selection text and background is normal.
Any ways, I will see if I can override the selection text color in css.
from ssleuth.
It's XP SP3. Now with Fx 31.0.
However it appears to be related with visual themes because with default theme the selection color is as it should be. When I change to any other theme than the selection color is like on previously attached screenshots. I've also tested on a fresh Fx profile with the same results.
When colorization is enabled this happens only on colorized address bars (non-encrypted connections have proper selection color).
from ssleuth.
Okay. Thanks for the details. Unfortunately supporting other themes etc. is way too much for an add-on that focuses on security :(
Even to make sure that things don't break in the default, and that too in 3 platforms (win, linux, mac) is way too much work. Hope you understand.
On the other hand, if you know style sheets and can submit a patch/pull request, I will be happy to apply it. The SSleuth css file can be found here : https://github.com/sibiantony/ssleuth/blob/master/content/skin/ssleuth.css
The ones responsible for urlbar colorizing are defined under #urlbar
from ssleuth.
Of course I'm talking about Fx visual themes (personas), not OS themes. I've tried with ::-moz-selection (modified local ssleuth.css from xpi), but without luck. It looks like related to transparency (image is below address bar) and "accentcolor" parameter of themes.
from ssleuth.
Yes. I meant the same. Be it personas or Fx appearance themes or even OS themes, it is a lot of work to keep each of them happy.
Besides, Fx themes would change the default styling a lot, and they might even have ways to invert colors of selection based on the text color. Perhaps this problem should be addressed in the themes.
I'm glad that URL colorizing is not enabled by default. You can simply disable the colorization if your themes do not play well with the colorization.
from ssleuth.
Actually colorization does not work with any theme (except default). I've installed other address bar customizing addon called Location Bar Enhancer. When user clicks address bar all customizations are removed. Maybe this could be solution (to remove linear gradient when focused)?
from ssleuth.
Nope. The focus on urlbar and applying different style doesn't somehow seem to work.
Secondly, which theme are you using ? I tried with a dark theme in Firefox (FT DeepDark) - which would introduce a dark background with a lighter text color. It also has an inverted selection color which would work fine with the dark theme. Now once I enable colorzing in SSleuth I can see the problem you described. This is because, my linear gradient is from a lighter color towards white.
If instead I make the gradient go towards transparent background, it will be much worse with darker themes, as the text will be unreadable. (color text on dark background)
Also I don't want to play with the selection colors either. That would be incompatible in many cases.
I will have a look in the weekend - but I don't see a universal fits-for-all solution.
Also, I'm not very happy with the colorizing as it is now (which is both a linear gradient towards white + color text ). So If you have some other/better ways of doing colorizing, keep me posted.
from ssleuth.
I use "Three Wolf Moon Shirt". Also it does not work with "Red Juicy Strawberries" and few others which I still had installed. So I tried to look into repo for working themes and I'm surprised to find many, like "Eco theme", "waves y lilavo", "Green Green Grass" and others (dark and light).
Unfortunately it seems that dark/light theme is not the reason as for example "Firefox Organic Grass" (dark, light text) - selection is ok, but "Grazing in the Grass" (dark, light text) - selection is reversed. And now "Deepdark" (50:50 light/dark, dark text) - selection is ok. I couldn't find "FT DeepDark" theme.
This is not a big problem, but as it behaves differently than expected and is quite visually problematic (however selection is not that often used) so I decided to report an issue.
from ssleuth.
Yes. No problem. This issue actually reminds of 'painting the bike-shed' :)
Any ways, I will keep this open. Whenever I'm making any major css changes, will keep this in mind. At the moment this issue is not a priority for me.
from ssleuth.
Related Issues (20)
- Opinion on not publishing releases on GitHub anymore HOT 3
- Feature request: monitoring of certificate life cycle HOT 1
- e10s: Mark your addon as compatible HOT 2
- Provide API to get SSL statistics from Javascript code HOT 2
- Button for initiating ssltest HOT 2
- Feat. Req.: Option to show other hashes, esp. SHA1, & match against https://www.grc.com/fingerprints.htm HOT 5
- Add support for X25519 HOT 2
- Lower score when Cloudflare certificate is used HOT 2
- Wrong detection with TLS 1.3 HOT 5
- Web extensions are the future HOT 39
- Request function to disable rating on non https pages HOT 1
- Displaying Connection Details For Wrong Domain HOT 2
- Extended Validation is always false HOT 6
- Missing space in validity with time HOT 3
- Abandoned? No v57? HOT 2
- Suggestions on coloring & legibility
- Show certificate transparency information HOT 1
- Liberapay
- Information about Cipher Suite Key exchange , Signature, etc unavailable in Basilisk / Palemoon browser HOT 1
- TLS for legacy Firefox HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ssleuth.