Changed indent after `@section` with multiple arguments (from version 1.11.13) about blade-formatter HOT 4 CLOSED

shufo commented on August 29, 2024 1

Changed indent after `@section` with multiple arguments (from version 1.11.13)

from blade-formatter.

Comments (4)

kawahara-kunio commented on August 29, 2024 1

Sorry, example above is not good.
Actually, it is a more complicated structure as shown below.
A blade file uses extends with layouts/test.blade.php

somePage.blade.php

@extends('layouts.test')

@section('title', 'This is title')

@section('content')
  <div class="someClass">
    This is content.
  </div>
@endsection

layouts/test.blade.php

<!DOCTYPE html>
<html lang="{{ str_replace('_', '-', app()->getLocale()) }}">

<head>
  <meta charset="UTF-8">
  <meta name="viewport" content="width=device-width, initial-scale=1.0">
  <title>@yield('title')</title>
</head>

<body>
  <div class='content'>
    @yield('content')
  </div>
</body>

</html>

With this situation, from 1.11.13, the blade file (somePage.blade.php) will be formatted as shown below.

@extends('layouts.test')

@section('title', 'This is title')

@section('content')
<div class="someClass">
  This is content.
</div>
@endsection

from blade-formatter.

shufo commented on August 29, 2024 1

Fixed by #331. Thanks @schelmo!
And release is at https://github.com/shufo/blade-formatter/releases/tag/v1.12.1

Thanks for reporting the issue @kawahara-kunio!

from blade-formatter.

schelmo commented on August 29, 2024

but isnt your code invalid?
if the second parameter is filled, the section is already ended and you will get an exception:

InvalidArgumentException
Cannot end a section without first starting one.

from blade-formatter.

shufo commented on August 29, 2024

I also encountered an exception on Laravel v8.54.0

❯ composer show | grep laravel/framework
laravel/framework                  v8.54.0 The Laravel Framework.

<!DOCTYPE html>
<html lang="{{ str_replace('_', '-', app()->getLocale()) }}">

<head>
    <meta charset="utf-8">
    <meta name="viewport" content="width=device-width, initial-scale=1">

    <title>Laravel</title>

    <!-- Fonts -->
    <link href="https://fonts.googleapis.com/css2?family=Nunito:wght@400;600;700&display=swap" rel="stylesheet">
~~~~
</body>
@section('content', 'title')
<div class="some-class">
</div>
@endsection

</html>