Issue when trying to upload cached s3 file about shrine

[janko]

What changed is that this functionality got extracted into a separate parsed_json plugin. The reason for this is that I intended to make a plugin for enabling multiple files uploads in the same column, and having this functionality in the base made things more complicated, so I thought it would be more easily managed.

I initially thought that this would only be required in the case where a JSON string is submitted in the form, and the web framework parses that JSON. However, I see that this use case is completely valid, and I also used this functionality in the existing app (which I didn't update with the 1.0 release). Even though in the meanwhile I've put the plugin for multiple files on hold (I find it too difficult to implement properly, and not important enough at the moment), I would still like to have this path open.

I'm not sure if it was the right decision to move this into a plugin, I will see if adding it back would still leave the path open for the potential multiple files plugin. Otherwise I will update the documentation to be explicit about accepting only JSON strings (and the example app as well).

[Chocksy]

@janko-m ok ignore this it seems because of me setting avatar_data column with some json/hash string and then trying to set @user.avatar again was giving me that error. I'll close this.

[vcavallo]

Hello.

I'm having the same error.

Shrine::InvalidFile (<ActionController::Parameters {"id"=>"988c14e239761adbec83c00f91ce0e42.png", "storage"=>"cache", "metadata"=><ActionController::Parameters {"filename"=>"tiny.png", "size"=>148, "mime_type"=>"image/png", "width"=>3, "height"=>3} permitted: true>} permitted: true> is not a valid IO object (it doesn't respond to         #read, #eof?, #rewind, #close)):

As far as I can tell (this is my first run-in with Shrine, trying to replace the half-baked ActiveStorage) I'm doing fairly normal stuff implementing a direct upload solution with S3. I'm expecting this json reference to the cached version (which is getting uploaded to S3 just fine) to trigger the full save / promote behavior, but instead I'm getting this error.

Is the issue here actually the ActionController::Parameters bit getting in the way?

[vcavallo]

Fixed by calling .to_json on the params hash in the controller.

[jrochkind]

@vcavallo Alternatively, I believe you just need to add the parsed_json plugin to shrine, such as with Shrine.plugin :parsed_json.

Or, sometimes instead of sending these things back as separate params, people send them to Rails as a serialized JSON string in the first place -- which is what most of the shrine examples show -- in which case it would just work.

Any of those approaches should be fine.

[vcavallo]

thanks. i actually tried parsed_json right before this and for some reason it didn’t make any difference.

…

On Mon, Apr 29, 2019 at 6:03 PM, Jonathan Rochkind ***@***.***> wrote: ***@***.***(https://github.com/vcavallo) Alternatively, I believe you just need to add the parsed_json plugin to shrine, such as with Shrine.plugin :parsed_json. Or, sometimes instead of sending these things back as separate params, people send them to Rails as a serialized JSON string in the first place -- which is what most of the shrine examples show -- in which case it would just work. Any of those approaches should be fine. — You are receiving this because you were mentioned. Reply to this email directly, [view it on GitHub](#24 (comment)), or [mute the thread](https://github.com/notifications/unsubscribe-auth/AAYNQ34EKE63LUEU7BUKS3LPS5WDDANCNFSM4BVZDG3Q).