Coder Social home page Coder Social logo

Introduce Phive about shopware HOT 11 CLOSED

shopware avatar shopware commented on May 17, 2024
Introduce Phive

from shopware.

Comments (11)

szepeviktor avatar szepeviktor commented on May 17, 2024

After that you may consider reducing the repo size by removing those tools https://help.github.com/en/articles/removing-sensitive-data-from-a-repository

from shopware.

mitelg avatar mitelg commented on May 17, 2024

hey @szepeviktor
I'm currently working on moving our CI tooling from platform to the development template. so the main repo size will be decreased. I will take your issue and your PR into account 👍
thanks for your contribution

from shopware.

szepeviktor avatar szepeviktor commented on May 17, 2024

All right.

from shopware.

szepeviktor avatar szepeviktor commented on May 17, 2024

moving our CI tooling from platform to the development template

@mitelg Does it mean that platform contribution (PR-s) won't be checked?

from shopware.

mitelg avatar mitelg commented on May 17, 2024

just a little hint 😊 as we are shortly before our first release, it will may take some time, as I don't want to struggle up our CI pipeline before the release 😉

from shopware.

mitelg avatar mitelg commented on May 17, 2024

@mitelg Does it mean that platform contribution (PR-s) won't be checked?

Currently there are no checks here on github anyway 😁 all checks are done internally on bitbucket and bamboo.
I will take that to my task 😉

from shopware.

szepeviktor avatar szepeviktor commented on May 17, 2024

What a shame! You develop modern code and use Atlassian products? No words can describe their quality.

from shopware.

szepeviktor avatar szepeviktor commented on May 17, 2024

I don't want to struggle up our CI pipeline before the release 😉

My base package for developer teams includes these 3 zero-coverage tests:

  1. parallel syntax check
  2. coding standards check (this check can do much more than its name suggests, e.g. find var_dump-s or detect dead code)
  3. static analysis

It costs nearly nothing to introduce them, and keeps your code quality very high even if you don't have time to write unit/functional tests.

from shopware.

mitelg avatar mitelg commented on May 17, 2024

Don't get me wrong here, we already use these tools 😊
but if I now move phar files from here to there, or introduce phive, I have to adjust our CI. and this is mostly not done in five minutes 😉

from shopware.

janbuecker avatar janbuecker commented on May 17, 2024

What a shame! You develop modern code and use Atlassian products? No words can describe their quality.

We have plans to migrate to an internal GitLab instance and we may can use parts of it's CI configuration for travis ci like we are doing with Shopware 5.

from shopware.

janbuecker avatar janbuecker commented on May 17, 2024

Some weeks ago, we've evaluated phive as replacement for the phar files. At the end of the day, the key servers are really unreliable and not all tools are available with a signature, which does not make much sense right now. We'll keep an eye on phive and once it's more mature, we'll evaluate it again.

from shopware.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.