Cursor based iteration about maintenance_tasks

[nvasilevski]

I think it's safe to close. Feel free to reopen if released functionality is not what was initially requested. Thanks

[sj26]

(This might be related to #207.)

[etiennebarrie]

How do you think you would declare a collection to be iterated with cursor enumeration? Currently we have ActiveRecord::Relation => enumerator_builder.active_record_on_records => JobIteration::ActiveRecordEnumerator => JobIteration::ActiveRecordCursor
or
ActiveRecord::Batches::BatchEnumerator => enumerator_builder.active_record_on_batch_relations => JobIteration::ActiveRecordBatchEnumerator.

What kind of object would we return from collection? I guess we'd need to use a class method and the collection builder strategy to handle a ActiveRecord::Relation differently?

[github-actions]

This issue has been marked as stale because it has not been commented on in two months.
Please reply in order to keep the issue open. Otherwise, it will close in 14 days.
Thank you for contributing!

[nvasilevski]

I think this must have been addressed by #859

Once the PR mentioned above gets released, maintenance tasks will be able to specify any column(s) to be used as a cursor. It's important to note that the cursor should represent a unique combination for job-iteration to work properly

@sj26 Let us know if that's something you were looking for! Thanks

[gmcgibbon]

https://github.com/Shopify/maintenance_tasks/releases/tag/v2.6.0 includes that change.

Can this be closed?