Comments (5)
When you say default is app, is it that is someone omits a specification for what they want to create, it creates an app?
Exactly, I think we agree here: Drop the first question and default to app.
I'm also not clear what the other two proposed flows would look like so we could chat about this !
Rather than using the CLI as a single command to generate the app, the goal is to end up with something more sophisticated and behaves more like an assistant they callout to throughout their store development experience.
I've talked about other potential commands such as: audit
, lint
or doctor
for checking for common mis-configuration and migrate
for performing migrations of API changes from different versions of hydrogen. I also see potential for deploy
, serve
and build
, but all TBD.
Within the create
command, we could offer subcommands that devs could run after the initial app is created. A component
command for adding a new custom React component with all the fixings (css file, graphql query, test files, etc...) is one idea that makes a lot of sense to me (again TBD).
All that is to say: Initially we will just have h2 create
that generates an app. Eventually we might offer other subcommands such as component
, but app will still be the default when this is omitted.
from hydrogen-v1.
We could also maybe open up the admin in the area where they would find their storefront token.
This assumes they've created a private app (soon this is going to be replaced with a custom app) and since you can have many, each with a separate access token, we wouldnt know which one to use? But i like where you're going with this flow... I would consider this a nice to have for now and not part of phase 1, as we sort out what custom apps look like
I think we have an API to get/create custom apps. From memory Shopify CLI uses it. Would be cool to explore this down the line!
from hydrogen-v1.
The first one is basically useless right now and might be better as a top-level parameter. h2 create would be h2 create component and h2 create app and h2 create someOtherThing. The default could be app.
+1 to making this a top-level parameter. Generally I think if we can help you get started in as few steps as possible that would be ideal.
When you say default is app, is it that is someone omits a specification for what they want to create, it creates an app?
I'm also not clear what the other two proposed flows would look like so we could chat about this !
we should consult a content strategist (cc @morganmccunn would that be possible?)
Apparently we do have someone joining the broader CS team soon! Let's start with our preferred approach and we can review with them.
We could break features into multiple specific questions
Fewer steps are better imo. I liked the select menu you offered in previous iterations. I do think we need to distinguish between require set up steps, and optional add ons. (ie. you need to these required things to spin up a hydrogen storefront, the others are optional if you have a specific use case or dev preference)
We could also maybe open up the admin in the area where they would find their storefront token.
This assumes they've created a private app (soon this is going to be replaced with a custom app) and since you can have many, each with a separate access token, we wouldnt know which one to use? But i like where you're going with this flow... I would consider this a nice to have for now and not part of phase 1, as we sort out what custom apps look like
It might be a good idea to sync with the folks designing the UX of the channel in the admin.
Going to flag @mediumjones so this is on his radar! However we aren't blocked by that work as this CLI tool will likely be available first to spin up a hydrogen storefront .
from hydrogen-v1.
@cartogram got it! Love this. I agree 100% with the direction and we can iron the details as we go, but starting with the broader app is the right first priority.
from hydrogen-v1.
Closing for now - feel free to re-open/transfer to place where the CLI is being developed!
from hydrogen-v1.
Related Issues (20)
- "Itβs missing some props that are..." (/api/hydrogen/components/cart/cartshoppaybutton)
- Shopify Hydrogen App crashes
- [BUG] CartCheckoutButton resolved to an invalid checkout page URL while BuyNowButton works fine HOT 5
- "CartLineProvider is not being given..." (/api/hydrogen/hooks/cart/usecartline)
- useQuery throws an error saying useQuery isn't exported when using in a custom hook HOT 2
- server-side redirects, preserving legacy Shopify URL patterns HOT 4
- [BUG] cannot obtain current URL in client code HOT 3
- [BUG] Oxygen is not defined Error on Deployment
- Hydrogen App not starting in Local Env. HOT 17
- [BUG] unclear docs regarding environment variable usage
- [BUG] 'Request Entity Too Large' error when POSTing to internal api routes HOT 1
- [BUG]
- Shop Pay Button not customizable with className provided HOT 1
- [BUG]
- [BUG] Back to Storefront from Checkout on Safari ios Error
- [BUG] linesRemove and linesAdd do not support promises
- [BUG]
- [BUG] HOT 2
- [BUG]
- [BUG]
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hydrogen-v1.