Coder Social home page Coder Social logo

Comments (22)

shlomif avatar shlomif commented on August 28, 2024 1

The solver is working fine in the latest build, so I am closing this bug. Thanks @Programator2 and all!

from pysolfc.

shlomif avatar shlomif commented on August 28, 2024

With the binary Installer, I am getting this error on a windows 7 x86-64 VM - http://www.shlomifish.org/Files/files/images/pysolfc-2.1.3-in-a-win7-vbox-vm.png . @Programator2 : any ideas?

from pysolfc.

Programator2 avatar Programator2 commented on August 28, 2024

Oh right, I see that pysol.exe needs Microsoft VC++ redistributable v100:

D:\pysol_win_dist\dist>dumpbin /dependents pysol.exe
Microsoft (R) COFF/PE Dumper Version 14.10.25019.0
Copyright (C) Microsoft Corporation.  All rights reserved.


Dump of file pysol.exe

File Type: EXECUTABLE IMAGE

  Image has the following dependencies:

    USER32.dll
    SHELL32.dll
    *MSVCR100.dll*
    KERNEL32.dll
...

We have two options:

  • bundle the dll with the binary using py2exe
  • bundle a vcredist installer with the installer

I'm inclined towards the second option. What do you think @shlomif ?

from pysolfc.

shlomif avatar shlomif commented on August 28, 2024

from pysolfc.

Programator2 avatar Programator2 commented on August 28, 2024

Visual C++ Redistributable (vcredist) is a package that installs MSVCR***.dll library to a system.

With the second option, if someone who doesn't have msvcr100.dll downloads the 7z archive, it won't work because the library would be included only with the installer.

With the first option, both 7z archive and installer would work on a system without msvcr100.dll.

Otherwise there are no differences.

from pysolfc.

shlomif avatar shlomif commented on August 28, 2024

@Programator2 : getting it to work from the 7z archive is not a big priority. Do what you see fit. Thanks!

from pysolfc.

Programator2 avatar Programator2 commented on August 28, 2024

No problem.

from pysolfc.

shlomif avatar shlomif commented on August 28, 2024

@Programator2 : now I am getting this error dialog box upon installing in my win7 vm - http://www.shlomifish.org/Files/files/images/pysolfc-2.1.3-in-a-win7-vbox-vm--install-error.png . Can you look into fixing it?

from pysolfc.

Programator2 avatar Programator2 commented on August 28, 2024

Hm, strange. I'll look into it.

from pysolfc.

shlomif avatar shlomif commented on August 28, 2024

from pysolfc.

shlomif avatar shlomif commented on August 28, 2024

Thanks @Programator2 ! On my win 7 vm, PySol FC now installs and runs successfully. One problem is that the solver for FreeCell (and I presume for black hole and all in a row as well) is disabled, but it's still very good progress. thanks again.

from pysolfc.

Programator2 avatar Programator2 commented on August 28, 2024

Great! I'll look into enabling the solver.
We can also bundle the fc-solve binary together with the installer, as it was the case with version 2.0 installer.

from pysolfc.

shlomif avatar shlomif commented on August 28, 2024

from pysolfc.

shlomif avatar shlomif commented on August 28, 2024

@Programator2 : any news regarding the Freecell solver? Note that there is now also http://www.shlomifish.org/open-source/projects/black-hole-solitaire-solver/ but I'm not sure how popular these two games are, so integrating it is not too critical. Anyway, do you need any help? Thanks.

from pysolfc.

Programator2 avatar Programator2 commented on August 28, 2024

@shlomif Sorry for not responding. Yes, solver will work when it's bundled with the pysol binary. I just need a zipped version of fc-solve. Could you add an artifact for that in fc-solve appveyor? It should be the 32-bit version. Aftwerwards, I'll just bundle it with pysol.

from pysolfc.

shlomif avatar shlomif commented on August 28, 2024

@Programator2 : I can, yes. Does it have to be statically linked? Or can I just put fc-solve.exe and freecell-solver.dll together? Note that there are also some data files for presets/etc. though their location can be relative to the binary.

from pysolfc.

Programator2 avatar Programator2 commented on August 28, 2024

@shlomif You can put them together. Keep the folder structure as it is when it's installed and it should be ok. Thanks!

from pysolfc.

shlomif avatar shlomif commented on August 28, 2024

@Programator2 : thanks! I'll be getting to that

from pysolfc.

Programator2 avatar Programator2 commented on August 28, 2024

@shlomif fc-solve is now bundled with the installer, see 1aa4315

from pysolfc.

shlomif avatar shlomif commented on August 28, 2024

from pysolfc.

shlomif avatar shlomif commented on August 28, 2024

@Programator2 : thanks! The solver works fine for freecell and for Seahaven Towers, but doesn't for Baker's Dozen. I think I'll have to build the .zip with the rights limits.

from pysolfc.

Programator2 avatar Programator2 commented on August 28, 2024

@shlomif You're right. Sounds good.

from pysolfc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.