Comments (20)
Why has this project been hidden on github for years? On Sourceforge this year I mentioned that adding SVG support would have benefits, and now I feel a complete idiot, because I see that 12 months earlier this was already being discussed over here on Github!!!
Do people actually WANT help with this project? It's a great project, it needs some more love. What's the best way to move this forward? And by 'this' I don't mean SVG support, I mean the whole project.
It's not clear to me whether there's any regression tests available for this project. Are there unit tests? Before moving to Python 3, surely a comprehensive set of tests is needed?
from pysolfc.
Ahah, I assumed shlomif is an alias for skomoroh, they seemed kind of similar to me. :(
I can appreciate that it's attractive to work on actual code and make the changes to move to Python 3. But I really do think that before doing that we need an automated test suite, that can be set up on a build server such as Jenkins, so we can be confident of minimising regressions.
I have a lot of experience doing this in C#, C++, etc, but none in Python unfortunately (though I'd like to learn). Indeed I have relatively little experience of Python, I can read it ok, but I'm not yet into Pythonic style.
If necessary, we need to refactor code so that the GUI part is rather separate, to make testing easier.
It would be great if we could find someone with experience of testing Python code, setting up unit tests etc.
from pysolfc.
@jan-kleks : thanks for your suggestions. I agree that supporting SVG cards would be a good idea. I don't immediately see how the UI could be "modernised" but I'm opposed to getting rid of the menu bar, and replacing it with a GoogleChromium/GNOME 3-like main menu button. Regarding playing directly on the desktop - wouldn't a full screen mode be a better idea (and an easier to implement one)?
All that put aside, separate feature requests should be in separate issues/entries for better handling of closing/resolving/etc.
from pysolfc.
from pysolfc.
from pysolfc.
It's easier to give advice than to actually write code and implement it.
Indeed so! "Those that can, do. Those that can't, make suggestions"! :)
Github, git, python (2 and 3), Travis CI, Pysol code itself, Tk gui, ... there is much to learn. :(
I'm not even sure what is appropriate discussion in issues threads, am I creating clutter? Normally I'd take this kind of discussion to a mailing list, or perhaps even send private mail (can't do that, having read http://www.shlomifish.org/meta/FAQ/#refer_or_address I'd be racked with indecision between all the possibilities! ;) ). Besides, I agree that public discussion helps others, private mails are rarely useful.
As you can guess, I'm quite keen on regression testing. Does the Travis CI system only test the master, or can it be told to test selected (or all) branches as well?
I'm sorry, I'm very conscious I'm dragging this discussion off topic.
from pysolfc.
from pysolfc.
I feel it's still on topic, but you can also reach me on IM/etc. here - http://www.shlomifish.org/me/contact-me/ . there's also a chatroom for PySol on freenode.
Afraid I'm not a great one for IM/IRC/etc.
I think Travis tests all branches by default - or at least those that contain a .travis.yml file. Moreover, it also tests the commits on the pull requests when they are filed.
That's useful.
I'm having trouble finding our other interchanges on Github, it doesn't seem to tell me where I've commented. But in mail (now deleted) I noticed you responded to my comment about flake8. Thx for that, I'd supposed flake8 was the name of some solitaire variant you were testing, or some such. Seeing your response caused me to question my assumption, I googled, ahah, flake8 is a Python tool. Yet more learning needed! ;) :/
from pysolfc.
I'm sorry, but I'm unclear in the resolution of this issue. Does PySolFC now support SVG cardsets/graphics?
from pysolfc.
@AntumDeluge : my mistake - it was closed by mistake. Reopening. There is no support for svg yet.
from pysolfc.
I started implementing preliminary support for loading kpat's SVG cards here: https://github.com/shlomif/PySolFC/tree/svg-support . Building it requires chasing some dependencies using apt/dnf/etc. and may not be a portable process yet. I'd like to share some screenshots and screen recordings soon.
from pysolfc.
Nice! Can't wait to see how it works out.
I've been working on converting GreyWyvern's cardset to SVG.
from pysolfc.
This is a screenie of the SVG cards in action - also see https://www.shlomifish.org/Files/files/images/pysolfc--svg-cards--preview0.1.0.webp . Enjoy!
from pysolfc.
Nice work. Will the SVG images scale with the window when resized?
from pysolfc.
I have two remarks that may be related:
- cards have wrong aspect ratio, they are narrower than the kpat original
- graphics on the cards look jagged, like there's some anti-aliasing or interpolation issue
from pysolfc.
Nice work. Will the SVG images scale with the window when resized?
That is the plan, but AFAI can tell, they currently do not.
from pysolfc.
I have two remarks that may be related:
* cards have wrong aspect ratio, they are narrower than the kpat original * graphics on the cards look jagged, like there's some anti-aliasing or interpolation issue
Both of these symptoms are expected due to the way it is currently done. The branch will require more work.
from pysolfc.
@Programator2 : I've done some work on that and you can see the results here - https://www.shlomifish.org/Files/files/images/pysolfc-svg-support--v0.1.1.webp . Please let me know if there's an improvement.
from pysolfc.
Nice job, card graphics look definitely better now.
There's one little thing I've just noticed - left edges of diamond suite cards are shifted a bit to the right. Is it because of the image files? I see that this also happens in KPat.
from pysolfc.
@Programator2 : thanks for the input. There is still some work to do.
from pysolfc.
Related Issues (20)
- Hanafuda Four Seasons Win Not Recognized HOT 4
- create a DIFFICULTY LEVEL to be used by the user HOT 7
- GNOME Software says PySolFC is unsafe HOT 2
- [Question] What is the official stance with regards to multiplayer card games? HOT 1
- 3.0 release HOT 13
- Updated solitaire wizard
- Themes are working for me on Windows 11.
- Themes aren't working for me in Windows 11. HOT 1
- Card flipping animations do not respect animation speed setting in Android HOT 1
- Add a "Back" button to menus in Android
- Request: Make Touch mode Drag-and-Drop the default. HOT 4
- suggestion: in games with only one, two or three syiuteslloe player to select which suite are in play.
- suggestion: allow "zero value" moves
- Broken Card Dealing in Spider (2 Suit) HOT 4
- Klondike 3 draw HOT 2
- Clean up duplicate images - GIFs and PNGs HOT 4
- game finished message buggy? (zero used hints) HOT 2
- PySol FC's Language Cannot be changed away from English HOT 2
- Preferences not saved on Android 13 HOT 1
- rules / doc mismatch in KingCell HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pysolfc.