Validate the Build on creation about build

[zhangtbj]

On creation of a Build, also need to validate that the formats in spec are valid.

• Like git url
• Like out image path
• Like builder image
• Like resource limit

[qu1queee]

@sbose78 I´m taking this one, fyi

[sbose78]

Go ahead! :)

[qu1queee]

@sbose78 for this particular issue, it seems most of the controllers lack of unit tests. For the verification of specific resources, I think the best place is during the reconciliation. For this we need to fake some artifacts, like the client and the manager.

Can you please take a look on https://github.com/redhat-developer/build/compare/master...qu1queee:qu1queee/83?expand=1 . I have a prototype on how to do this, by using counterfeiter. The code its WIP(dirty), but I think the idea is clear.

Let me know what you thing pls.

[sbose78]

// NewReconciler returns a new reconcile.Reconciler
func NewReconciler(mgr manager.Manager) reconcile.Reconciler {

Did you export these to be able to use them from /fakes/* ? If that's the only reason, I would recommend not exporting them, rather bring the fakes into the same package. Suggesting this so that we don't inadvertently expose something we were generally not planning on exposing :)

What do you think?

[sbose78]

Ah, you are using package build_test :) I like that!

[sbose78]

Looks good, go for it @qu1queee !

[qu1queee]

This card have been completed, closing.