Install well known strategies when the operator starts up about build

[sbose78]

Will the build v2 replace the build v1 in OpenShift in future?

No plans as of now. Both will co-exist for a significant amount of time.

And do your CORE components (Such as Build v1 in OpenShift) also need to be managed by OLM lifecycle?

In openshift 4, everything is managed/lifecycle'd by operators.

Out of these operators:

• The control plane ( "core". ) components are CVO operators ( CVO lifecycles them ) https://github.com/openshift/cluster-version-operator

• Non-control plane operators / optional operators are OLM operators ( OLM lifecycles them )

Because Build v1 predates Operator framework / OLM , and is not even a CRD, it is today lifecycle'd by CVO. But there are plans to eventually move everything ( incl Build v1 ) that's not needed in the control plane to be managed by OLM.

[zhangtbj]

Thanks a lot for the introduction Shoubhik! :)

[sbose78]

@zhangtbj @qu1queee Thoughts?

[zhangtbj]

Hi @sbose78 ,

I agree and we need to install the well-known cluster scope strategoes so that every one in every namespace can use it without any additional configuration directly.

About How ?
When the operator starts up, install the well known strategies in the cluster scope.
[Jordan] I think first of all, we need to modify the hack/crd.sh to install the cluster scope buildstrategies: https://github.com/redhat-developer/build/blob/master/hack/crd.sh#L20-L24
Then modify the README.md to tell users how to use it: https://github.com/redhat-developer/build/blob/master/README.md

If they change, ensure they are reconciled in the ClusterBuildStrategy controller/reconciler.
[Jordan] Right now, we don't have any trigger policy, so I think there is no too much we can do in the ClusterBuildStrategy reconcile logic.

I think we can:

• If ClusterBuildStrategy is updated, add a new label in all builds which belong to this ClusterBuildStrategy that JUST tell the ClusterBuildStrategy is updated, and end-user can notice that and manually decide what he want to do next

• Do nothing in our Alaph, and plan it with trigger feature support in next release, such as there is a new type of trigger: buildStrategy trigger, if the BuildStrategy is updated, auto-rebuild the image.

[sbose78]

Note: the hack/ scripts are for local development only.

[sbose78]

Remind me: do you plan to have Olm lifecycle the Operator?

[zhangtbj]

NO! :), and do you plan to have OLM lifecycle the Operator?

I hope it is not, because it is also an important reason that we choose the Build v2.

With OLM, we have to take many effects to solve the OLM dependencies in our system...

[sbose78]

We do.

OLM is more like a package manager: helps us package the operator, manifests and metadata as a bundle - and then version and lifecycle them as a whole.

However, you can skip using that packaging - just like software installed without a package manager doesn't affect any functionality/code at all.

Nothing should change for your if you didn't want to use olm :)

[zhangtbj]

Cool, I remember our team member tried to use some redhat operator but reported some OLM import packages error, so we didn't touch that. :(

But it is great if we can skip it easily.

Anyway, go ahead of your OLM support. And we may ask your help then about how to skip it. Thanks! :)

[sbose78]

👍 Ideally, you should see nothing in this repository. I'll keep the bundling/packaging metadata in a different repo to keep this repo pure :-)

[zhangtbj]

Awesome! :)

[qu1queee]

I will add my comments on this, I just want to check something first, therefore I need more time.

[zhangtbj]

And one more question Shoubhik,

Is there any background behind the OLM lifecycle the build operator ?

Will the build v2 replace the build v1 in OpenShift in future?

And do your CORE components (Such as Build v1 in OpenShift) also need to be managed by OLM lifecycle?

Thanks!

[qu1queee]

@sbose78 similar to this issue, what do you think about installing the CRDs during runtime, see current manual approach. I could PR this, not sure how critical this is though. It will make the flow from zero to a running controller easier.

[sbose78]

@sbose78 similar to this issue, what do you think about installing the CRDs during runtime

Let me start a thread for operator/CRD lifecyle.

[qu1queee]

this is already done, can we close?