Coder Social home page Coder Social logo

Comments (4)

Avni-Sharma avatar Avni-Sharma commented on August 18, 2024 2

It would be also good if conditions can be used as a list of Condition as mentioned here https://github.com/redhat-developer/build/blob/master/pkg/apis/core/v1alpha1/condition_types.go#L24 . and then Succeeded that is used here https://github.com/redhat-developer/build/blob/master/pkg/controller/buildrun/buildrun_controller.go#L317 can be used as a ConditionType. More conditions can then be added to the conditions list.

For more reference refer- https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#typical-status-properties

from build.

zhangtbj avatar zhangtbj commented on August 18, 2024 1

Hi all,

I think we could show some basic build information in the status of the build:

  1. Like using corev1alpha1.Status to show the Succeeded, Reason, StartTime and CompletionTime informations
  2. If possible, provide the step lists to show each step status and result
  3. If possible, show the git info (url or revision) info to let the user know which git commit they used for this build
  4. If possible, show the base image/builder image info to let the user know which image (version or tag) they used to build their image.

(Item 3 and 4 can be useful for the future trigger support)

And I think the Item 1 is the first priority because right now, Build v2 just update the Status once taskrun provide the status, it cannot provide the status if there is any build native error, and cannot know the basic info like Succeeded or Time.

Hope it is helpful.

from build.

bamachrn avatar bamachrn commented on August 18, 2024

Thanks for the input, I believe we can show the logs in case of error in the build process. so that user knows what is breaking where. Build stages (steps) are available in build v1 I believe we can use some kind of similar things in build v2 as well.

from build.

qu1queee avatar qu1queee commented on August 18, 2024

This topic have been widely discussed, the latest state around the main enhancements are:

  • BuildRun supports conditions(already in master branch)
  • Build is gonna get an enhancement inside its Status field, WIP at #463 (comment)

from build.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.