Coder Social home page Coder Social logo

Comments (6)

zhangtbj avatar zhangtbj commented on July 19, 2024

Also FYI @sbose78 :)

from build.

sbose78 avatar sbose78 commented on July 19, 2024

@zhangtbj Thanks!

If the WATCH_NAMESPACE is set to "", the operator should be able to watch CRs in all namespaces with Role,RoleBinding..

What do you think? Though I need to check how that's going to work with cluster-scoped CRDs.

from build.

zhangtbj avatar zhangtbj commented on July 19, 2024

Hi @sbose78 ,

I took a look other operators in openshift repo, such as:
https://github.com/openshift/cluster-monitoring-operator/blob/master/manifests/0000_50_cluster_monitoring_operator_02-role.yaml
or
https://github.com/openshift/cluster-image-registry-operator/blob/master/manifests/02-rbac.yaml#L2

They all use ClusterRole and ClusterRoleBinding

And I think although change WATCH_NAMESPACE is set to "", there will be the permission issues that the role cannot operate the resources from cluster scope like the above error message.

from build.

zhangtbj avatar zhangtbj commented on July 19, 2024

Hi @sbose78 ,

It is an important requirement for us that we need to run the operator at cluster scope to handle the build for all of namespaces.

I provided a PR and verified in my env, could you review and see if it is acceptable for the current design:
#68

Thanks!

from build.

zhangtbj avatar zhangtbj commented on July 19, 2024

The PR is merged, thanks a lot!

from build.

sbose78 avatar sbose78 commented on July 19, 2024

I realized we need this anyway since we now have a cluster-scoped CRD 🥇

from build.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.