Coder Social home page Coder Social logo

Comments (7)

gabemontero avatar gabemontero commented on August 18, 2024 1

@adambkaplan I feel like we can either close this in favor of shipwright-io/community#23 and any items opened as a result of that, or we should cite this issue as something address by that SHIP,

The former feels better but I'm enough on the fence to not hit the close button unilaterally

Thoughts?

from build.

sbose78 avatar sbose78 commented on August 18, 2024

Today openshift build v1 API allows for injection of config map content under the source tree

Could you help me with a scenario, please?

from build.

gabemontero avatar gabemontero commented on August 18, 2024

Today openshift build v1 API allows for injection of config map content under the source tree

Could you help me with a scenario, please?

In this case I think our docs do a sufficient job of capturing this one. See https://docs.openshift.com/container-platform/4.3/builds/creating-build-inputs.html#builds-input-secrets-configmaps_creating-build-inputs

from build.

otaviof avatar otaviof commented on August 18, 2024

Interesting use-case, @gabemontero. Putting myself as a final user, it would come handy to share common resources between different builds, therefore, it would act as another point of extensibility, which currently we only offer on BuildStrategy.

Good idea, I think we should pursue it!

from build.

adambkaplan avatar adambkaplan commented on August 18, 2024

/kind feature

This would be useful in two contexts - dovetailing on the discussion in #419:

  1. Using ConfigMap and Secrets as content in the image to be built (sources)
  2. Using ConfigMap and Secrets as supplemental information used in the build, but is not present in the final image (volumes)

from build.

adambkaplan avatar adambkaplan commented on August 18, 2024

There are a few subtle differences:

  • SHIP-0022's objective is to let strategy authors define volumes that could be optionally altered by the developer.
  • We don't have a SHIP yet that lets developers arbitrarily mount Secrets or ConfigMaps into a Build/BuildRun. That is a logical follow-up to SHIP-0022.

from build.

gabemontero avatar gabemontero commented on August 18, 2024

There are a few subtle differences:

* SHIP-0022's objective is to let strategy authors define volumes that could be optionally altered by the developer.

* We don't have a SHIP yet that lets developers arbitrarily mount Secrets or ConfigMaps into a Build/BuildRun. That is a logical follow-up to SHIP-0022.

I'm not sure how the existing API or new api proposed in https://github.com/shipwright-io/community/blob/32b3d0f8f802d98a605bc2670fe2094229bdbb98/ships/0022-build-strategy-volumes.md would change based on your 2 points ^^

I have a guess or two perhaps, but instead, would it be feasible to construct yaml tweaks to either existing API or you proposed API to make it clear what you are getting at ?

thanks

from build.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.