Comments (7)
+1 on making it LocalObjectRef, Gabe.
Thanks for pointing out.
The API does need a lot of love, and I'm going to be investing in having it aligned with basic best practices.
Feel free to point out any absurdities.
from build.
Not sure what aspect you're suggesting changing, @gabemontero
if you mean the type, yeah, a LocalObjectRef would make sense.
if you mean the name.... "SecretSource" was a poor name choice that we've regretted ever since. (trying to explain "secrets you are using as source input content" vs "secrets you are using to access the source from git" is always painful), so i'd hate for us to carry that name forward.
from build.
from build.
Please feel free to provide more API feedback, this repo is like a google doc proposal, with working code. Happy to make rapid changes to get to an initial good-looking state of the API.
Updated the API to look like this:
---
apiVersion: build.dev/v1alpha1
kind: Build
metadata:
name: example-build-buildpack
spec:
# Git Source definition
source:
url: https://github.com/sclorg/nodejs-ex
credentials:
name: github-auth-sbose78
# Strategy defined in the buildpacks-v3 CR
# in the 'openshift' namespace. Namespace is optional.
strategy:
name: "buildpacks-v3"
namespace: "openshift"
# Build to be run in this image.
builderImage: "cloudfoundry/cnb:bionic"
# Generated image.
output:
image: "image-registry.openshift-image-registry.svc:5000/sbose/nodejs-ex"
credentials:
name: github-auth-sbose78
from build.
I would not assume "source" will always mean "git source", so tying those fields together(along with the embedded url+ credentials fields) in that way seems to limit future evolution.
I would expect something more like:
source
sourceType1
fieldsForSourceType1
sourceType2
fieldsForSourceType2
etc.
which
- allows you to add new source types (input types?) in the future
- allows each to have its own unique urls/credentials/etc
- allows you to have multiple sources/inputs
from build.
๐ Agreed, that's how I was thinking of bringing in API support for things like "I want to build an image out of this jar"
from build.
This issue original concern have been already addressed. Iยดm closing this for now. Feel free to re-open if needed.
from build.
Related Issues (20)
- [FEATURE] Move Readme Try It Section to BETA HOT 5
- [FEATURE] v0.13 Bump Tekton and Kubernetes dependencies
- [FEATURE] Document usage of OCIArtifact source type HOT 2
- [BUG] Endless reconcile of build when strategy kind is unknown
- [SHIP-0038] Use Release Branches for Releasing HOT 4
- [tech-debt] Release Workflow Action No Longer Maintained
- [BUG] BuildStrategy: Cannot Use Context Dir as Working Directory HOT 4
- [FEATURE] Conditional step HOT 1
- [FEATURE] Build Strategy from Tekton Task/Pipeline HOT 1
- [BUG] Automatic release README update needs to be fixed HOT 4
- [FEATURE] Provide Storage Version Migration from v1alpha1 to v1beta1 HOT 1
- [BUG] git clone issue on newest Git version HOT 3
- [FEATURE] Windows Containers/Node Support HOT 2
- [FEATURE] Support another technology to define and orchestrate the image creation inside a pod HOT 2
- [BUG] Unit tests run fine with `go test`, but fail when used with Ginkgo CLI HOT 1
- SHIP-0039: Allow node selector on `Build` and `BuildRun` to be set HOT 7
- SHIP-0039: Allow tolerations on `Build` and `BuildRun` to be set
- SHIP-0039: Allow custom scheduler to be used for `Build` and `BuildRun`
- [FEATURE] Establish a release cadence based on Tekton LTS releases HOT 2
- [BUG] The container name for shipwright build webhook doesn't match the environment variable HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from build.