align git source secret type with k8s/buildv1 types about build

[sbose78]

+1 on making it LocalObjectRef, Gabe.
Thanks for pointing out.

The API does need a lot of love, and I'm going to be investing in having it aligned with basic best practices.

Feel free to point out any absurdities.

[bparees]

Not sure what aspect you're suggesting changing, @gabemontero

if you mean the type, yeah, a LocalObjectRef would make sense.

if you mean the name.... "SecretSource" was a poor name choice that we've regretted ever since. (trying to explain "secrets you are using as source input content" vs "secrets you are using to access the source from git" is always painful), so i'd hate for us to carry that name forward.

[gabemontero]

On Mon, Feb 17, 2020 at 5:29 PM Ben Parees ***@***.***> wrote: Not sure what aspect you're suggesting changing, @gabemontero <https://github.com/gabemontero> if you mean the type, yeah, an ObjectRef would make sense.

Sorry yes I meant the type @bparees if you mean the name.... "SecretSource" was a poor name choice that we've

…

regretted ever since. (trying to explain "secrets you are using as source input content" vs "secrets you are using to access the source from git" is always painful), so i'd hate for us to carry that name forward. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#22>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA3NU5DMLFOIZPCFJVDJQJLRDMFUFANCNFSM4KWZMP2A> .

[sbose78]

Please feel free to provide more API feedback, this repo is like a google doc proposal, with working code. Happy to make rapid changes to get to an initial good-looking state of the API.

Updated the API to look like this:

---
apiVersion: build.dev/v1alpha1
kind: Build
metadata:
  name: example-build-buildpack
spec:
  # Git Source definition
  source:
    url: https://github.com/sclorg/nodejs-ex
    credentials:
      name: github-auth-sbose78

  # Strategy defined in the buildpacks-v3 CR 
  # in the 'openshift' namespace. Namespace is optional.
  strategy: 
    name: "buildpacks-v3"
    namespace: "openshift"

  # Build to be run in this image.
  builderImage: "cloudfoundry/cnb:bionic"

  # Generated image.
  output:
    image: "image-registry.openshift-image-registry.svc:5000/sbose/nodejs-ex"
    credentials:
      name: github-auth-sbose78

[bparees]

I would not assume "source" will always mean "git source", so tying those fields together(along with the embedded url+ credentials fields) in that way seems to limit future evolution.

I would expect something more like:

source
  sourceType1
    fieldsForSourceType1
  sourceType2
    fieldsForSourceType2

etc.

which

1. allows you to add new source types (input types?) in the future
2. allows each to have its own unique urls/credentials/etc
3. allows you to have multiple sources/inputs

[sbose78]

👍 Agreed, that's how I was thinking of bringing in API support for things like "I want to build an image out of this jar"

[qu1queee]

This issue original concern have been already addressed. I´m closing this for now. Feel free to re-open if needed.