Getting MissingAttributeError when submitting a value in the form with trailing whitespace about mobility

[shioyama]

My guess would be that it's paper trail. What if you remove it and see if you see the same issue?

[shioyama]

Hmm I'm not sure what's going wrong. I can see the error running your code, but removing all other stuff from the model it still occurs. However I don't see it in isolated Mobility specs, so something in your projects setup or gemfile is conflicting I would suppose...

[shioyama]

Ah ok it's compatibility with the strip_attributes gem (should be obvious). This is not a bug but a compatibility issue.

[shioyama]

I'm probably going to have to close this since I can't really guarantee compatibility with every other gem.

[jmuheim]

Thanks a lot for finding the problem.

Do you have a more specific guess on what's the problem with strip_attributes gem? I will create an issue on its side then.

[shioyama]

@jmuheim can you try pointing your Gemfile to the branch in #102 ?

gem 'mobility', github: 'shioyama/mobility', branch: 'convert_attributemethods_to_plugin'

This branch extracts the code overriding the attributes hash into a plugin which is not enabled by default. I believe this should fix the problem with strip_attributes.

[shioyama]

@jmuheim See above, can you please try using the branch in #102? I am going to merge that branch to fix the issue here.

[jmuheim]

I'll do soon, sorry for the delay.

[shioyama]

I've merged #102. If you use the latest on master now, you should not have any conflict with strip_attributes anymore.

This will be released shortly as a change in 0.3.

[jmuheim]

Thanks a lot for your effort! 👍

[jmuheim]

Hey there!

I tried to use the master branch, and while the problem disappeared, a spec failed.

The spec checks that each translated column offers a small icon next to the input. This icon is added in a custom SimpleForm input:

    if object.respond_to?(:translated_attribute_names) && object.translated_attribute_names.include?(attribute_name.to_s)
      help_blocks << template.content_tag(:span, nil, class: 'fa fa-globe') + ' ' + t('simple_form.inputs.better_text.multi_language')
    end

It seems that in the master branch the object doesn't respond to :translated_attribute_names anymore. But in the source the method still exists, so I'm unsure why it doesn't work like this anymore.

I'm using 0.2.3 until I can fix this.

Any help is highly appreciated.

[shioyama]

Hmm, I've checked and for me, using the latest (0.3.3) the model instance responds to translated_attribute_names.

Are you sure that your model instance really doesn't respond to translated_attribute_names? Maybe it's something to do with simple form.

[shioyama]

I notice the problem is (possibly) connected to paper trail. I was actually thinking of creating a small gem for using mobility with paper trail.

I'm suspecting the issue might be because the attributes method on the model no longer includes translated attributes in 0.3.x.

Can you try setting attribute_methods to true in your config, like this:

Mobility.configure do |config|
  config.default_backend = :column
  config.accessor_method = :translates
  config.query_method    = :i18n
  config.default_options[:fallbacks] = { de: :en }
  config.default_options[:attribute_methods] = true
end

?

[shioyama]

btw, this is a wrap-up of recent changes: http://dejimata.com/2017/12/5/mobility-0-3-ready-for-prime-time

[shioyama]

This is the view code you're talking about right?

[jmuheim]

Yes this is one of the views that have a form with translated fields.

…

On 05 Dec 2017, at 13:15, Chris Salzberg ***@***.*** ***@***.***>> wrote: This is the view code <https://github.com/jmuheim/base/blob/0ef3adda2c12950298c9de5ec7df5effd4e46bb7/app/views/pages/_form.html.slim#L29-L35> you're talking about right? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#97 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABuxx4jnCQhOTkaiWY4bpFLEwJEpeovAks5s9TPGgaJpZM4PZ8x8>. <https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png> <https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png> <https://github.com/shioyama/mobility> <https://github.com/jmuheim/base/blob/0ef3adda2c12950298c9de5ec7df5effd4e46bb7/app/views/pages/_form.html.slim#L29-L35> <#97 (comment)>

[shioyama]

Ok I've confirmed this issue in your repository, and indeed adding attribute_methods: true to the config fixes it (but brings back the original issue you posted here). I'm debugging now, very strange...

[shioyama]

Ah, never mind, I see the issue. translated_attribute_methods is still in Mobility, but only on the model class, not on the instance, see here. This should really not be extracted into the plugin.

I'll fix this and release a new patch version. Thanks for noticing the issue!

[shioyama]

@jmuheim ok issue is fixed now, try 0.3.4.

[jmuheim]

It's working, thank you so much. I love mobility gem. ❤️