Comments (6)
Hi I would like to take a go at the bug. I will check the http replys.
from sherlock.
Appreciate the fix @pandyah5! It does seem like message is the right way to go here. I was able to validate and merge into master. Changes should be live in a few mins. Welcome to the contribution tree.
To keep things tidy for the next reviewers...
Cults3D and Star Citizen remain.
from sherlock.
Kick was addressed in #2123, which was merged about two days ago. The fix however was applied within Sherlock itself and not to the manifest, so it would require an update (relates to waf filtering).
If you're running the PyPI (pip) or Homebrew image then it'll be pushed out shortly.
Otherwise...
Seems that Cults3D doesn't like dots in usernames. Likely needs a regexCheck added.
EyeEm and Star Citizen are also reproducible.
Other sites listed I was unable to reproduce. Could be a regional difference. Without any indication as to which ones are false positives, that's all I've got.
Feel free to open a pr if you have luck resolving the F+ @Manishmrgn !
from sherlock.
PyPI image updated with mentioned WAF fingerprinting changes for Kick (homebrew should soon follow, whenever the automation starts)
from sherlock.
Debugging the issue:
@ppfeister I glanced through the code and the issue for EyeEm seems to be in the detection algorithm. The errorType is set to status_code, however a simple curl request to an unavailable username in EyeEm shows the response code as 200.
Potential solution
All unavailable usernames are accompanied by the error message:
"Whoops! We can't find the page you're looking for..."
If you wish I can make a PR for making this change and fixing it for this website. I understand that error message is the least reliable detection mechanism hence if you have better ideas I am all ears for it.
from sherlock.
@ppfeister I have opened a PR addressing the issue for EyeEm. I was going to look into the other site but noticed that @Manishmrgn wanted to work on it. If you need a hand with the other websites feel free to hit me up @Manishmrgn 😄
from sherlock.
Related Issues (20)
- Make torrequest (and other deps) optional HOT 2
- https://www.facebook.com/profile.php?id=61558096995421&mibextid=LQQJ4d HOT 2
- archive.org returning 200 response for any query HOT 4
- sync-json-data workflow failure HOT 3
- I keep getting errno 13 HOT 8
- Adding a demo walkthrough of Sherlock to docs HOT 2
- Heavy-R F+ / APClips F+ HOT 8
- Watson HOT 1
- CyberDefenders false positive
- Zhihu false positive HOT 1
- Requesting support for: x.com (formerly Twitter) HOT 2
- Installation from sources HOT 5
- Only run GitHub action if it is actually needed
- False positive for: babyRU HOT 3
- False positive for: Fiverr HOT 1
- Include searching a username with a tag functionality HOT 8
- Run error but could be user error HOT 5
- Latest pull 0.14.4 exits with error. HOT 2
- zsh: no matches found: test{?}test HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sherlock.