Coder Social home page Coder Social logo

Comments (2)

ppfeister avatar ppfeister commented on May 27, 2024 1

(not the maintainer, just a random)

While not useful for me personally, it sounds like an interesting option to add, if done well. I don't like the is_Game key, though. After a while, that would get quite bulky with other categories being added.

How about key tags accepting a str or list of str

List (items with multiple tags):

"SteamGroup": {
    "errorMsg": "No group could be retrieved for the given URL",
    "errorType": "message",
    "tags": [
        "nsfw",
        "game"
    ],
    "url": "https://steamcommunity.com/groups/{}",
    "urlMain": "https://steamcommunity.com/",
    "username_claimed": "blue"
  }

Singlet:

"SteamGroup": {
    "errorMsg": "No group could be retrieved for the given URL",
    "errorType": "message",
    "tags": "game"
    "url": "https://steamcommunity.com/groups/{}",
    "urlMain": "https://steamcommunity.com/",
    "username_claimed": "blue"
  }

This could be normalized within sherlock by a quick

site_tags = net_info.get["tags"]
if isistance(site_tags, str):
    site_tags = [site_tags]

allowing all checks to just be a if "game" in site_tags

Categories could (imo, should) likely be enumed for consistency.

from sherlock.

Gregory-rt avatar Gregory-rt commented on May 27, 2024

I would like to work on this, if the team would be interested.

from sherlock.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.