Comments (15)
could you assgin me
from quoteverse.
well the issue goes for twitter button also,
can you fix that also?
i am uupdating the issue title
from quoteverse.
yeah sure
from quoteverse.
assigned,
star the repo, and do the work
from quoteverse.
The error occurred due to adding a new div through the event listener of the Twitter and Facebook icon
from quoteverse.
The error occurred due to adding a new div through the event listener of the Twitter and Facebook icon
i dont think so,
do you understand the problem?
from quoteverse.
The error occurred due to adding a new div through the event listener of the Twitter and Facebook icon
did you understand the problem?
Whenever I add the inner HTML through this event listener the bug occurs
I comment on this lines inner HTML then its working fine
from quoteverse.
The error occurred due to adding a new div through the event listener of the Twitter and Facebook icon
did you understand the problem?
Whenever I add the inner HTML through this event listener the bug occurs I comment on this lines inner HTML then its working fine
exactly,
innerHTML.
but one thing you have to fix is that.
you should not comment code inside code.
either keep it or delete it.
from quoteverse.
Make a PR , if you fix it
from quoteverse.
The error occurred due to adding a new div through the event listener of the Twitter and Facebook icon
Did you understand the problem?
Whenever I add the inner HTML through this event listener the bug occurs I comment on this lines inner HTML then its working fine
exactly, innerHTML. but one thing you have to fix is that. you should not comment code inside code. either keep it or delete it.
I mean I just explain you the error so for facebook i added the link directly to element not after the event listener
but for twitter the link is customize so I just need to this in that way i can access customize link
from quoteverse.
but you can fix it by using another event rather than mouse enter.
think about it.
from quoteverse.
with another event same problem occur
from quoteverse.
with another event same problem occur
well,
if you use "load", it wont occur.
but you have to fix other thing with it.
can you fix both facebook and twitter?
from quoteverse.
with another event same problem occur
well, if you use "load", it wont occur. but you have to fix other thing with it. can you fix both facebook and twitter?
Yes I tried this but then the button will do not work
from quoteverse.
ok, just fix the facebook button,
and make a PR.
i will see the rest
from quoteverse.
Related Issues (20)
- [FEATURE]: Contributors page UI need more cool looking design HOT 3
- [FEATURE]: Hover effect for see all contributors button and the click to contribute button HOT 2
- [BUG]: Cant-See-Share-Options HOT 6
- [BUG] Missing Favicon HOT 8
- [OTHER] Add quotes for the art category HOT 2
- [BUG]: Once a background color is selected, there is no way to go back to the white bg color except when we refresh the page. HOT 3
- [OTHER] Enhance Share with button HOT 5
- [FEATURE]: Add toaster for better user interaction HOT 3
- Change the Twitter logo to X logo HOT 2
- [FEATURE]: Add a 'download quote as image' option in share buttons HOT 1
- [FEATURE]: <To Add Heading to the Application (QuoteVerse)> HOT 3
- [Enhancement] : improve the UI HOT 1
- [FEATURE]: <adding Love category quotes>
- [Improvement] <Expanding the Quotes Database> HOT 2
- [BUG] Duplication In Quotes.js HOT 1
- [Improvement] <Home Screen UI Can be improved> HOT 11
- [BUG]: Config to control code formatting HOT 5
- [BUG]: Fix Generate Button Functionality HOT 1
- [BUG]: Contributors Page doesn't show all contributors HOT 1
- [BUG]: Logo not appearing on the Contributor Page's Tab HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from quoteverse.