Coder Social home page Coder Social logo

Comments (10)

brendalf avatar brendalf commented on May 31, 2024 1

I would like to fix this. What you think, @shankarpandala?

from lazypredict.

shankarpandala avatar shankarpandala commented on May 31, 2024 1

Sure go-ahead

from lazypredict.

shyamcody avatar shyamcody commented on May 31, 2024 1

I couldn't basically figure out where the issue is generated from as both setup.py and requirements_dev.txt contains the modules I wanted to include in dependency. @brendalf seemed to know how to resolve it, so I have unassigned myself.

from lazypredict.

shankarpandala avatar shankarpandala commented on May 31, 2024 1

@brendalf and @shyamcody

I whole heartedly appreciate all the efforts you both are putting to make things right with lazypredict.

Please let me if there is anything I can help from my side.

Big down side is the current code is not suitable for cross validation and hyperparameter tuning. Please let me know you guys have any ideas with less efforts.

from lazypredict.

shyamcody avatar shyamcody commented on May 31, 2024 1

Maybe we need to incorporate some autoML tool that will take a model object in and give out the best parameters. I have already raised a separate issue for the hyperparameter optimization; and reviewing some automl frameworks as I am new in that. Will make some comments once I get a good idea. Currently, optuna and H20ai seems promising.

from lazypredict.

brendalf avatar brendalf commented on May 31, 2024

Working on the issue, I found this line inside the setup.py file:
python_requires=">=3.8, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, !=3.4.*",

This line was added on commit e3371de from @shankarpandala.
Is there any special reason for python >= 3.8? I guess that the remaining conditions can be removed, what you guys think?

from lazypredict.

brendalf avatar brendalf commented on May 31, 2024

It also appears that this issue happens in the latest version available, tag v0.2.7, because the setup.py there only installs the click as requirement.

setup.py on v.0.2.7:

requirements = ['Click>=7.0', ]

setup(
    ...
    install_requires=requirements,
    ...
)

The setup.py inside the dev branch already fix this issue, with the commit 45fad6b from @shankarpandala.

setup.py on dev:

requirements = [
    "click>=7.1.2",
    "joblib>=0.16.0",
    "lightgbm>=2.3.1",
    "numpy>=1.19.1",
    "optuna>=1.5.0",
    "pandas>=1.0.5",
    "pytest>=5.4.3",
    "PyYAML>=5.3.1",
    "scikit-learn>=0.23.1",
    "scipy>=1.5.2",
    "six>=1.15.0",
    "tqdm>=4.48.0",
    "xgboost>=1.1.1",
]

setup(
    ...
    install_requires=requirements,
    ...
)

There still some bugs with the dependency list I'm fixing right now.

from lazypredict.

shankarpandala avatar shankarpandala commented on May 31, 2024

@brendalf Travis CI is failing for this commit stating requirements.txt not found. Can you check why it is failing even the file is there.

from lazypredict.

brendalf avatar brendalf commented on May 31, 2024

@shankarpandala off course. I will take a look

from lazypredict.

brendalf avatar brendalf commented on May 31, 2024

@shankarpandala, PR #318 should fix this issue.

from lazypredict.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.