Coder Social home page Coder Social logo

Comments (7)

justin808 avatar justin808 commented on May 18, 2024

This one is up for grabs until we assign somebody!

from react-webpack-rails-tutorial.

robwise avatar robwise commented on May 18, 2024

@justin808 I agree with this approach in general. While making the generators, I was having to first make my own custom apps in order to be sure that what I was generating would actually be a working app. The more we can make the tutorial the model on which to base our generators, the better. Obviously, there are some things in the tutorial that should not go in the generators, as the former is showing off and the latter is KISS. But things like the containers folder, the bundles folder, components using es2015 class syntax, etc. should all agree between the two.

from react-webpack-rails-tutorial.

justin808 avatar justin808 commented on May 18, 2024

@josiasds and @MaMute Is this issue still valid?

from react-webpack-rails-tutorial.

josiasds avatar josiasds commented on May 18, 2024

@justin808 Yes, we should break SimpleCommentScreen into a container to handle the requests and a view component.

from react-webpack-rails-tutorial.

justin808 avatar justin808 commented on May 18, 2024

@josiasds can we close this issue?

from react-webpack-rails-tutorial.

josiasds avatar josiasds commented on May 18, 2024

@justin808 It looks like item 3 is still valid. SimpleCommentScreen is the only component that still doesn't follow the rules in the project. We have AJAX calls and HTML rendering together, and I think we should split it into a container and a view component.

I'll try to take it this weekend.

from react-webpack-rails-tutorial.

justin808 avatar justin808 commented on May 18, 2024

@josiasds Can we close this one?

from react-webpack-rails-tutorial.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.