Comments (7)
This one is up for grabs until we assign somebody!
from react-webpack-rails-tutorial.
@justin808 I agree with this approach in general. While making the generators, I was having to first make my own custom apps in order to be sure that what I was generating would actually be a working app. The more we can make the tutorial the model on which to base our generators, the better. Obviously, there are some things in the tutorial that should not go in the generators, as the former is showing off and the latter is KISS. But things like the containers folder, the bundles folder, components using es2015 class syntax, etc. should all agree between the two.
from react-webpack-rails-tutorial.
@josiasds and @MaMute Is this issue still valid?
from react-webpack-rails-tutorial.
@justin808 Yes, we should break SimpleCommentScreen
into a container to handle the requests and a view component.
from react-webpack-rails-tutorial.
@josiasds can we close this issue?
from react-webpack-rails-tutorial.
@justin808 It looks like item 3 is still valid. SimpleCommentScreen
is the only component that still doesn't follow the rules in the project. We have AJAX calls and HTML rendering together, and I think we should split it into a container and a view component.
I'll try to take it this weekend.
from react-webpack-rails-tutorial.
@josiasds Can we close this one?
from react-webpack-rails-tutorial.
Related Issues (20)
- Component Comment.jsx is using an insecure method to sanitize input --could suffer XSS atacks
- "Getting Started" doc not updated
- Provide example with react-rails HOT 2
- Update Rails 7, Ruby 3.1, and add ruby-debug gem HOT 1
- Clean up docs for react-webpack-rails-tutorial HOT 1
- Convert to Tailwind
- Separate workflows
- Migrate from Heroku to Control Plane HOT 1
- Replace `xvfb-action` with `coactions/setup-xvfb`
- The README.md file link in the docs/linters.md is outdated
- Update old documentation HOT 1
- Improve tests consistency HOT 1
- Resolve flashing while loading the page
- Rails 7 Jbuilder ActionView::MissingTemplate Error HOT 1
- Update to Rails 7.1
- Fix issues with Redis HOT 1
- Fix i18n issue (Missing locale)
- Not getting live comments on the ReScript page HOT 1
- No commit hash on the deployed project
- Add CI for auto deployment to ControlPlane HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-webpack-rails-tutorial.