Comments (15)
Yes, this tool is so cool and useful, and I am eagerly waiting for the new version that supports the awesome Bootstrap 4.0. Hope we can use it as soon as possible 👍
from bootstrap-sass-loader.
@LukeQi Feel free to create a PR or advise me on what changes are needed.
from bootstrap-sass-loader.
I have created a fork of this package that supports Bootstrap 4:
github: https://github.com/markusjwetzel/bootstrap-v4-webpack
npm: https://www.npmjs.com/package/bootstrap-v4-webpack
Since Bootstrap switched from Less to Sass, there is no extra Bootstrap 4 Sass package. So it might be the best solution to integrate my fork into bootstrap-webpack someday when Bootstrap 4 is officially released. What do you think?
from bootstrap-sass-loader.
@markusjwetzel There is no way to file issues on your repo, but the peerDependencies
(bootstrap@twbs/bootstrap#v4-dev
) are incompatible with the version of bootstrap that is installed ([email protected]
). I'm not sure how you installed bootstrap, but what you have it not working for me.
from bootstrap-sass-loader.
@markusjwetzel Please let me know how close this is being ready to merge. If it's close, I'll try to take a look at this in the next few days.
from bootstrap-sass-loader.
I have enabled issues for my repository and changed back bootstrap peer dependency to "bootstrap": "*"
. Please let me know if it works for you now. @maxbates
from bootstrap-sass-loader.
Think the *
syntax is wrong: https://docs.npmjs.com/files/package.json#peerdependencies
Also note (I believe) specifying ^4
won't work because it's alpha
from bootstrap-sass-loader.
@maxbates I am pretty sure that the syntax is not wrong. It works for me with these two lines in my packages.json
:
"bootstrap": "twbs/bootstrap#v4-dev",
"bootstrap-v4-webpack": "^1.0.1",
So I think you must do something wrong. Are you sure that you have installed bootstrap v4 correctly? I think that bootstrap v4 is not on npm yet. That's why I use the github repo branch "twbs/bootstrap#v4-dev"
instead.
@justin808 Yes, it should be ready. As I said I am not sure whether it is a good idea or not to merge it with this repo, but that's up to you. :)
from bootstrap-sass-loader.
npm (v 2.14.4) log reads:
npm ERR! peerinvalid The package [email protected] does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer [email protected] wants bootstrap@*
When installing bootstrap@twbs/bootstrap#v4-dev
, even if it appears as such in package.json, the version is still registered as [email protected]
I am running npm install bootstrap@twbs/bootstrap#v4-dev
from bootstrap-sass-loader.
We're going to merge this within the next day or so. Looks great!
We'll add one more setting in the config file:
bootstrapVersion: < 3 or 4 >
Here's the PR: #38
CC: @alexfedoseev, as he's going to take a look at this in about 12 hours and do some general refactoring to make the loader work with both, PLUS support CSS modules: #36
from bootstrap-sass-loader.
@markusjwetzel Please get in touch with us at either [email protected] or [email protected] if you want to join our slack room and possibly pair on these changes. @alexfedoseev is in Moscow time, which is closer to you. Thanks again for figuring this out!
from bootstrap-sass-loader.
@maxbates npm install bootstrap@twbs/bootstrap#v4-dev
works for me. I don't know how you have managed to install [email protected]
as there is no such version on npm. I am sorry, but I don't have any more ideas to solve your problem.
@justin808 This repo and my repo/pull request have different peer dependencies (bootstrap-sass
vs bootstrap
). And I guess they will even have different ones after the official release of bootstrap 4, because bootstrap will very likely put v4 sass files into the bootstrap
package.
So it is done by just adding one more setting bootstrapVersion: < 3 or 4 >
. Do you have a solution for this? What about creating a new repo shakacode/bootstrap-loader or someting like this for bootstrap 4?
from bootstrap-sass-loader.
WIP: shakacode/bootstrap-loader#1 Feel free to comment.
from bootstrap-sass-loader.
FYI -- we'll soon be transitioning to the name bootstrap-loader and the new loader which supports CSS modules and Bootstrap 3 & 4: shakacode/bootstrap-loader#1.
from bootstrap-sass-loader.
@alexfedoseev I think we're ready. Closing this issue and opening a new one with the migration checklist.
Example implementation here: shakacode/react-webpack-rails-tutorial#175
from bootstrap-sass-loader.
Related Issues (20)
- Cannot load files... HOT 4
- File to import not found or unreadable with sass-loader 1.0.3 HOT 9
- @import scss file hot reload HOT 2
- 1.0.7 ERROR: Could not find path to config.bootstrapCustomizations HOT 3
- How to debug when HMR stops working? HOT 4
- Weird relative path behaviour HOT 8
- getting it to work HOT 2
- how do i include bootswatch customizations for _variables and _bootswatch? HOT 5
- extract text plugin HOT 3
- Add global wrapper for CSS Modules HOT 1
- Loading only bootstrap styles HOT 6
- "1.a Complete Bootstrap" not working for me HOT 2
- Feature request: Ability to turn off scripts and dependency on jquery HOT 2
- Migration to bootstrap-loader HOT 1
- bootstrap-sass-loader with eslint-loader HOT 2
- How can I access bootstrap variables? HOT 11
- Unable to parse fonts HOT 1
- Style loader class name spaced HOT 1
- t
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bootstrap-sass-loader.