Comments (5)
I think you are correct. This is a violation that would break header installation for the shared library build. macros/classes.h should be moved to the public headers.
from shaka-packager.
Yes that’s a bit of a problem on my side as I am currently using libpackager. I have to manually copy the file macros/classes into include which is not great. Should I create a pull request to add macros/classes to the public include ?
from shaka-packager.
Yes, please!
from shaka-packager.
There is a CMake target that is meant to catch errors like these. I'm going to figure out why it didn't.
from shaka-packager.
Commands for configuring shared libs and building the link test, which compiles a simple application with libpackager and the public headers:
cmake -S . -B build/ -DCMAKE_BUILD_TYPE=Debug -G Ninja -DBUILD_SHARED_LIBS=ON
cmake --build build/ --parallel -- packager_link_test
It works. However, the main file includes only packager.h, which includes all the other header files except file.h. If we add file.h to packager.h, the build fails.
from shaka-packager.
Related Issues (20)
- NPM packages broken before v3.0.3
- Not support VVC/H.266 codec HOT 1
- Unable to run executable via NPM module on Apple Silicon (even with Rosetta 2 enabled) HOT 1
- ShakaPackager v3 doesn't generate <BaseURL> in MPEG-DASH manifest so that ShakaPlayer cannot play video completely.
- demux error HOT 2
- Packager fails to copy tmp files into place once its done when using a container volume + sshfs mount HOT 8
- Error building shaka packager in windows 10 HOT 2
- NALU length exceeds stream size HOT 2
- error: generic:18 Failed to write playlist HOT 3
- Shaka packager design in document HOT 3
- `ninja -C build pssh-box.py` not working HOT 5
- Packager Adaptation Set Switching values point to representation IDs instead of Adaptation Set IDs. HOT 1
- Error when using long path in input/output (Windows) HOT 4
- Shaka-packager's subtitle output and timing is broken for real-time flows when the input has "gaps/periods" without subtitle streams. HOT 3
- Packager Adaptation Set Switching doesn't work with forced command-line ordering HOT 1
- [DASH] Add content steering support.
- audioSamplingRate in representation is "0" for high sample rates HOT 2
- helpxml removed? HOT 1
- For Packaging webm to mpd i am getting (MUXER_FAILURE): Error adding sample to segment: Cluster::AddFrame failed
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from shaka-packager.