BOM doesn't count correct about freecad_fastenerswb

[shaise]

As I said, grouping makes issues. Please attach a sample file.

[shaise]

I think I fixed it. please check

[hpbmo]

Great, it counts correct, if the the screws etc. are in groups. Within my 3d printer design I use a lot of parts and groups. There also a lot screws, nuts and washers organised in groups. The fasterners where all placed with an older version expect 3 M4 screws with custom length 50mm. And this 3 screws show now an error:

FSSCrewObject object has no attribute itemText

The file is big, 13MB. If you are interessted, I will attach it.

With an other smaller design I find an issue with using Part. If I drop all Bodies inside the Part, the fasteners appears doubled in the model tree. If you try this with the attached file, you will see what happens. It's difficult to explain

Velotraeger v1.3.zip

Thanks again for your work

[shaise]

when do you get the 'itemText' error? when you create a bom?

[hpbmo]

The screw has an red exclamation mark at the symbol and when point on it there is the message poping up

[shaise]

Hi @hpbmo
I have fixed some issues now that can be related to this bug. You might need to recreate the screw again, since it might be corrupted. please test and tell me
shai.

[hpbmo]

Hi @shai

I had really to recreate the screw. Also, I had to recreate the washers wich doesn't base on a 'PartDesign Body' or a on 'Part Body'. If the base Object is a 'PartDesign Feature' it brakes the design.
Are the fasteners placed inside a Part, then quantity is still not correct. The washer are counted twice. They had to be placed inside the part, because it's rotated. Otherway they don't follow the Body.

hpb

Velotraeger v1.3.FCStd.zip

[shaise]

Hi @hpbmo
Regarding placing objects under parts, I am sorry, but I am not familiar enough with how this works inside FfeeCAD, so it is hard for me to fix.
shai

[shai]

Hi @shai

I had really to recreate the screw. Also, I had to recreate the washers wich doesn't base on a 'PartDesign Body' or a on 'Part Body'. If the base Object is a 'PartDesign Feature' it brakes the design.
Are the fasteners placed inside a Part, then quantity is still not correct. The washer are counted twice. They had to be placed inside the part, because it's rotated. Otherway they don't follow the Body.

hpb

Velotraeger v1.3.FCStd.zip

Hehe... Wrong person mention 😉

[hpbmo]

Hi @shaise

Regarding placing objects under parts, I am sorry, but I am not familiar enough with how this works inside FfeeCAD, so it is hard for me to fix.

You did a very good job with fixing the problem with the group, this helps a lot. And maybe you find a way.

My programming skills have remained at basic and turbo pascal some years ago ;-). So I have no idea, how I could help.

Thanks again
hpb

[luzpaz]

I'm confused, the original issue has been fixed ?

[hpbmo]

Hi @luzpaz

Sorry for the late response. I was quiet busy the last few weeks and didn't do anything with freecad / fastenersWB.
As far as I remember, the counting works fine if the fasteners are in the root tree or inside a group. As soon as you drag one of them inside a part the counting fails. I try it again in the next few days and post the result

hpb

[karliss]

Just got one more similar case of overcounting, in my case it was due to subShapeBinder. Adding one more case checking for parent.TypeId != 'PartDesign::SubShapeBinder' seemed to help.

[luzpaz]

@shaise ☝️