Comments (18)
yes, problem verified. It happens freecad when moved from OCC v7.1 to OCC v7.2
Looking into it
from freecad_fastenerswb.
Hey @shaise here is a downstream report https://freecadweb.org/tracker/view.php?id=3552
Please give a heads up when this issue is fixed so we can close said downstream report. Thanks!
Related forum post: https://forum.freecadweb.org/viewtopic.php?f=10&t=30074
from freecad_fastenerswb.
Sorry about that. I dug into the code, (its not mine) but could not find an easy fix. Do you know if ScrewMaker macro works for these types? If so, I will copy the solution from that. If not, I will try again as soon as I have time.
from freecad_fastenerswb.
OK, went back into it with a fresh mind, and found a fix. Problem should be fixed. Please check and close.
shai
from freecad_fastenerswb.
Tested and works great! Thx for fix
OS: Windows 10
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.18.14495 (Git)
Build type: Release
Branch: master
Hash: c717d1121d888fe6cfbd8971b5f59311a34b37bc
Python version: 2.7.14
Qt version: 4.8.7
Coin version: 4.0.0a
OCC version: 7.2.0
Locale: German/Germany (de_DE)
from freecad_fastenerswb.
Hi, is this issue back? I just installed what looks like the current version (last change in readme.md
is V0.4.15 04 Oct 2022
), and upon adding "hexagon socket countersunk head" screws got the following:
hexalobular screws on the left look ok, hex socket screws on the right are glitched again
from freecad_fastenerswb.
I will take a look at it, can you say what size and length are the hex screws?
from freecad_fastenerswb.
from freecad_fastenerswb.
I can not reproduce this issue with the current freecad version:
What version of freecad are you using?
can you attach the problematic file (zipped)
from freecad_fastenerswb.
You are right! It works fine in the current stable version:
Problem occurs in link branch, installed via snap:
As well as one built from arch package:
I also ensured all freecad installations share the same version of the fastener workbench. Looks like issue lies with the link branch.
from freecad_fastenerswb.
Please let realthunder know. Closing ticket as this is related to Link branch
from freecad_fastenerswb.
The original fix here is not appropriate. The reason it worked is most likely due to bug of OCC revolving may sometimes create solid regardless if the input face is closed or not. The produced geometry will fail the BOP test. The PR above simply closed the wire, which makes Part.revolve() return a valid solid. Please check if it covers all the cases.
from freecad_fastenerswb.
I have merged @realthunder 's solution. However this fix is only for non flat countersunk screws so I wonder if it solves the issue. @starcatter , can you please check if it works now with the link branch?
from freecad_fastenerswb.
Countersunk hex screw sockets are now modeled correctly:
However while playing around I noticed two things I think are new.
1 - set screws are sometimes modeled incorrectly, with the socket shape placed out of alignment:
Looks like it moved after generating the thread:
2 - after some operations on fasteners (changing types eg. M8->M6, adding thread) an object named "Shape" appears. This happens randomly / isn't always reproducible, but consistently happens after a few operations.
Both might be separate issues, I'll test if either happens in the stable branch weekly build. Here's the model I'm testing on:
5mm-plate.zip
from freecad_fastenerswb.
The extra shape also appears in the weekly build:
OS: Manjaro Linux (KDE/plasma)
Word size of FreeCAD: 64-bit
Version: 0.21.30492 (Git) AppImage
Build type: Release
Branch: master
Hash: b4578fb3eae842eb510a1bc055d07d369a67ce94
Python 3.10.6, Qt 5.15.4, Coin 4.0.0, Vtk 9.1.0, OCC 7.6.3
Locale: English/United States (en_US)
Installed mods:
* fasteners 0.4.15
* Assembly3 0.11.3
from freecad_fastenerswb.
Thanks for the report, working on it.
Can you save a file with a bad set screw and attach it?
from freecad_fastenerswb.
@starcatter
I think I fixed both issues. (no need for example file) Can you please test?
shai
from freecad_fastenerswb.
Looks fixed - I can't reproduce any of the issues after updating to the latest version. Thanks!
from freecad_fastenerswb.
Related Issues (20)
- FastenersCmd.FSViewProviderTree not JSON serializable HOT 20
- The die tool has the wrong profile. It creates the screw with the profile of a nut. HOT 3
- Parametric heatset inserts as an option? HOT 7
- Query parameters of standard fasteners via aliases HOT 3
- [Feature request] Add global "enabling/disabling" real thread calculation HOT 11
- Hide ISO or ASME parts HOT 2
- Changing the workbench license HOT 52
- Aliases for quivalent norms HOT 7
- [Problem] Countersunk holes feature is no longer needed HOT 6
- [BUG] Segementation fault when moving an object HOT 3
- List of pins HOT 4
- [Feature request] Custom Designation string for each norm HOT 4
- DIN 1624 is wrongly named HOT 3
- List of DIN Fasteners HOT 6
- Info-Display broken in AddonManger HOT 5
- [feature] nails HOT 24
- FreeCAD v0.21.2 Object of type FeaturePython is not JSON serializable HOT 8
- [feature] ASME/ANSI B 18.6.1 wood screws HOT 7
- [Discussion] Implementing GUI translation on Crowdin. HOT 12
- Roscas tipo rosca gas HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from freecad_fastenerswb.