Coder Social home page Coder Social logo

Comments (2)

stevenengler avatar stevenengler commented on June 6, 2024

It might also be worth fixing the "Dropped without calling safely_drop" errors, which cause panics in debug builds when unexpected flags are passed to the clone syscall. There are two return calls in clone_internal that don't properly drop the descriptor table's RootedRc before returning. (Also these error messages should probably say "explicit_drop", not "safely_drop".)

from shadow.

sporksmith avatar sporksmith commented on June 6, 2024

Added a test for this first. Over the course of which I learned:

  • We currently have a bug s.t. the signal handlers always get set to default in a child process. Whoops.
  • Experimentally it looks like CLONE_CLEAR_SIGHAND is ignored in a clone syscall; it only works in clone3. My guess is that the clone syscall only supports flags that fit in 32 bits; (clone3 explicitly adds support for 64-bit wide flags).

With those details sorted out, actually implementing the flag should be pretty simple.

from shadow.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.