Bottleneck v2.x seems to require redis, regardless of new Clustering setting? about bottleneck

[SGrondin]

EDIT: Bottleneck is now obfuscating its require call to prevent build tools from trying to inline redis.

Hi, this is definitely an issue with your build process.

The redis module is only imported within the RedisStorage constructor, which means Bottleneck only attempts to require that module when Clustering is enabled.

But I'm still pretty sure I know what issue you're running into with your build:
You need to tell whatever packaging tool you use to ignore the redis module. If you're using Browserify, you need to pass it the -u redis option. Packaging tools read the source code and find all the places where modules are required, then go read those modules and so on. Whichever packaging system you're using will definitely let you ignore certain modules.

[JamieWritesCode]

Looking deeper, this might be a Typescript issue, importing into Angular.

[SGrondin]

Here's Bottleneck's own build script

Bottleneck uses Browserify to provide a pre-made frontend bundle to be used by browsers. Nodejs users still require() Bottleneck as usual.

By the way, I've been seriously considering obfuscating the require('redis') line to hide it from packagers without affecting Clustering users.

[SGrondin]

The upcoming 2.2.0 release will be released this week. It contains a change that solves your issue without requiring you to ignore modules (as you should).

To be clear, it's normal and expected of you as an Angular/Webpack/Browserify/etc user to have to exclude modules sometimes, but if I, as a module author, can make your life easier without too much trouble, then I'll do it.

[SGrondin]

Version 2.2.0 has been released, which should eliminate this issue.

[JamieWritesCode]

Hey, thanks Simon. Apologies for not getting back to you on this one, I simply reverted to v1 at the time and didn't get a chance to revisit yet.

I have no doubt you are 100% right about the simple exclusion, but I appreciate your effort to update the package regardless. Looking forward to giving the new version a spin.

[SGrondin]

No worries! I hope v2 works great for you.

I was being extra clear in my previous message for those landing on this page from Googling a generic error like Module not found: Error: Can't resolve 'redis'.