thaismartcardreader.js's Introduction

Thai Smart Card Reader.js

This is implementation of smartcard node js module. That using PCSC API.

Installation

yarn add thaismartcardreader.js

For windows

Please install windows-build-tools as administrator before install this library.

Deprecated

"card-readed" event from Reader class using "card-inserted" instead
Access variable directly eg. person.cid using getter function by add prefix "get" and using camelCase eg getCid, getDoB

Example Code

You can find it in demo/GetAllData.js

API Document

Comming Soon in Version 0.3

Credit

Chakphanu for an APDU Command

familla for a report, on windows need to install windows-build-tools as administrator right.

thaismartcardreader.js's People

Contributors

Stargazers

Watchers

thaismartcardreader.js's Issues

Remove unused code in Reader.js

There are few commented out lines in Reader.js that seems to be duplicated with (or superseded by) README.md

https://github.com/sgnsys3/thaismartcardreader.js/blob/master/src/Reader.js#L43-L72

Revise usage of async/await in ReaderUtils.js

functions in this file seems like an odd mix of async/await and Promise.

https://github.com/sgnsys3/thaismartcardreader.js/blob/master/src/ReaderUtils.js#L8-L21

Could we consider changing this to use Promise or just declare function as async?

(see gist for syntax hi-lighted code: https://gist.github.com/varokas/87d0a4ffdeb344c97d50c5b834c78c18)

//Mock card object
let card = {
  issueCommand: new Promise(function(resolve, reject) {
    resolve("issueCommand");
  })
}

//Mock ResponseApdu
class ResponseApdu {
    constructor(rawResponse) {
        this.rawResponse = rawResponse;
    }
}

//Option 1: Use promise (similar to issueCommand: https://github.com/tomkp/smartcard/blob/2373b010790aa11cf8e9df740c5dd1368a0aae25/src/Iso7816Application.js#L38-L63 )
let runCommandPromise = (card) => {
  return card.issueCommand.then( rawResponse => new ResponseApdu(rawResponse) )
}
runCommandPromise(card).then(response => console.log(response))

//Option 2: Declare function itself as async (which is interchangable with Promise)
let runCommandAsync = async (card) => {
    let rawResponse = await card.issueCommand;
    return new ResponseApdu(rawResponse);
}  

runCommandAsync(card).then(response => console.log(response)); //Use as Promise

//Or use as async function in someother function
async function someOtherFn(card) {
    return await runCommandAsync(card);
}