Problem with custom node labels about semptools

[sfcheung]

I will draft a function in the branch match_node_names to address this issue.

[sfcheung]

I will draft a function in the branch match_node_names to address this issue.

We decided not addressing this issue by matching node names. Instead, another function for changing node names will be written.

[sfcheung]

I will draft a function in the branch match_node_names to address this issue.

We decided not addressing this issue by matching node names. Instead, another function for changing node names will be written.

I will draft the function in this branch:
change_node_labels

[marklhc]

I added an experimental function change_node_label2(), which takes a named list as input, but then I found out your suggestion in #53. The function is not currently exported.

[marklhc]

A bug has now been identified as set_curve() and set_edge_label_position() give an error when applying to objects returned by change_node_label(). Still need more investigation, but most likely due to these functions not using the names of the named vector returned. @sfcheung do you think we should change all functions to allow them use the names of the named vector/list for the labels if they could not find a match?

[sfcheung]

I added an experimental function change_node_label2(), which takes a named list as input, but then I found out your suggestion in #53. The function is not currently exported.

I drafted this function to_list_of_lists in the branch change_node_labels to make it easier to specify the elements to be changed by supplying a named vector, rather a list of lists. We could have used this approach for all relevant functions but it is too late to rewrite them now. There may also be situations in which named vector will not work. Therefore, we can revise relevant functions such that, if they detected the input is a named vector rather than a list of lists, they will be converted to a list of lists internally. Then all previous examples will still work while users have two options to specify the nodes or paths to be changed.

P.S.: I forgot which branch is the active branch that we should work on. Given that change_node_labels involves an urgent issue to handle, I drafted that function there.

[sfcheung]

A bug has now been identified as set_curve() and set_edge_label_position() give an error when applying to objects returned by change_node_label(). Still need more investigation, but most likely due to these functions not using the names of the named vector returned. @sfcheung do you think we should change all functions to allow them use the names of the named vector/list for the labels if they could not find a match?

Agree, @marklhc . I will revise related functions in the branch change_node_labels.

[sfcheung]

A bug has now been identified as set_curve() and set_edge_label_position() give an error when applying to objects returned by change_node_label(). Still need more investigation, but most likely due to these functions not using the names of the named vector returned. @sfcheung do you think we should change all functions to allow them use the names of the named vector/list for the labels if they could not find a match?

@marklhc, I revised edge_index(), which is used by set_curve() and set_edge_label_position(), following your advice on using the names of the named vector (...$graphAttributes$Nodes$names) if no match was found. This should solve the bug you found (the tests in test-change-node have been passed). I will check which other functions need to be revised similarly (I created #58 to keep track of this task).

[sfcheung]

I added an experimental function change_node_label2(), which takes a named list as input, but then I found out your suggestion in #53. The function is not currently exported.

I revised change_node_label() based on change_node_label2(), adopted your approach in finding a match and allowing for using a named list (rather than a list of lists).

[sfcheung]

I am closing this issue because it should be been fixed when addressing other issues. The brnach https://github.com/sfcheung/semptools/tree/change_node_labels up to 2fb1d0b passed all tests. The remaining tasks are addressed in #58. If necessary, we can reopen this issue later.