Comments (4)
I had similar issue, I hacked it like this:
implement has_broken
with boolean holder
fn has_broken(&self, conn: &mut MyConnection) -> bool {
if self.release_on_return_to_pool.get() {
return true;
}
...
pub struct MyConnection {
...
/// Indicates that we want to release this connection on return to pool (used for gracefull shutdown)
release_on_return_to_pool: Cell<bool>,
...
impl ProtocolRunnerConnection {
...
/// Mark connection as "destroy" when return back to pool
pub fn set_release_on_return_to_pool(&self) {
self.release_on_return_to_pool.set(true);
}
...
}
so when I have aquired connection and some error occures, I can decide, if to return connection to pool or to destroy it by calling set_release_on_return_to_pool
from r2d2.
@sfackler
if this solution is ok, I could maybe do pull request to your library,
btw. r2d2 is very cool and works perfectly for me
from r2d2.
This seems like quite the hack. Is there really no way of closing or returning a connection to the pool explicitly?
I'd expect something like
connection.close()
for example— or pool.reclaim(connection)
from r2d2.
FWIW I found one source that says connections are returned to the pool as soon as they go out of scope
from r2d2.
Related Issues (20)
- Is there a way to not keep idle connections? HOT 8
- `get_timeout` exceeds timeout HOT 11
- Can be used in the future such as tokio, async_std? HOT 1
- Use `compare_exchange` or `compare_exchange_weak` instead
- "Named" connections HOT 3
- Why example use `let pool = pool.clone()` in a for loop ? HOT 2
- Document relationship between `min_idle`, `idle_timeout` and `max_lifetime` HOT 1
- How to set timezone when linking HOT 1
- Release? HOT 1
- Allow hooking on connection get-from-pool and release-to-pool HOT 8
- Using behind proxychains HOT 1
- Seg fault with Postgres HOT 14
- Remove parking_lot dependency now that std's Mutex is faster than before HOT 3
- [Bug] CI test failure on arm HOT 4
- r2d2::Error should derive PartialEq and Clone HOT 4
- Pool building freezes when connections drop during initial setup HOT 4
- Does it support ssh2 sessions?
- Add a PooledConnection::pool() method HOT 3
- Fail Fast for Certain Errors
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from r2d2.