setzeus / crash-punks-v2 Goto Github PK

1. Major - Incomplete & Static Clothes Functions
While we only have one example head-collection NFT, the contract is currently missing a way to change either "torso" or "legs."

Additionally, change-avatar-head doesn't accept a contract as a parameter but instead just has the one example head contract as a fixed contract-call.

The change...functions need to be flexible enough where they accept a contract as a parameter since there will be multiple collections for one body part.

For that same reason...it might make more sense to track & update 3 separate whitelisted lists of collections (one for head, one for torso, or one for legs).

Or else what's stopping someone from assigning a head to a leg or vice versa?

2. Intermediate - Incomplete Admin System
Whenever we deploy a contract that requires admin functionality (such as whitelisting a collection for x/y/z), we need to make sure there's a way to both add & remove admins.

Otherwise, we risk not being able to ever hand projects off.

3. Minor - Extraneous Functions
There are a few extra variables I've removed such as "admin-one", "punk-limit" & "punk-index" that are unused along with their comments. Got confused for a second when I read "...keeps track of all punks pseudo-minted."

4. Minor - Incomplete Function Descriptions
From (redeem-digital-avatar...) & below you don't have @desc & @param comments for functions.

1. Minor - Extraneous Functions
There are a few extra variables I've removed such as "admin-one", "punk-limit" & "punk-index" that are unused along with their comments. Got confused for a second when I read "...keeps track of all punks pseudo-minted."

2. Minor - Didn't Remove References To Previous Projects
Highly encourage copying/pasting reliable contracts when possible, however, we have no excuse to remove these at some point. We cannot hand these over to a client or consider them "finished" until these small but meaningful details are cleaned up.