Comments (7)
@jorgenj Thanks for the question! maxAttempts can limit the number of attempts when interval defines an unbounded number of repetitions , for example R/PT15M. In the param description the example is indeed somewhat confusing so I will update that asap.
Using maxAttempts even if interval is bounded could be useful in testing for example.
I am currently revising the error handling / timeouts / retries sections and will definitely include this as well as many more clarifications in the docs.
from specification.
I can't tell if there's a reason why I might use interval field to limit retries over using the separate maxAttempts attribute, perhaps some guidance on when/why a user might use one vs. the other would be helpful to add to the docs?
One advantage I see over the separate fields is it's a nice succinct way to define a basic retry policy (retry 5 times with 2 minutes in between -> "R5/2M").
On the other hand, the concern is that this might get confusing when combined with functionality like progressive backoff. For example:
{ "interval": "R5/PT15M",
"multiplier": "1M"
}
At first glance, it's not clear whether this will have 15M between every retry, or follow an increasing series of backoffs (I personally would assume the progressive series (15m, 16m, 17m, ...)).
from specification.
@jorgenj all good points I am using your ideas atm as part of the workflow error docs updates. Will ping you to review PRs that have updates asap.
from specification.
@jorgenj i have taken the first step on this with just a small change interval/delay in PR #175.
Once that pr is merged we can move forward on the overall retry definition improvements.
from specification.
@tsurdilo I'm new to github issues, is it reasonable to assign this task to me? I'm not sure how to do that, is that something you can do?
from specification.
@jorgenj done
from specification.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
from specification.
Related Issues (20)
- Request to establish a ServerlessWorkflow community in China HOT 14
- workflow.id and workflow.key is duplicate HOT 8
- is it true that state transition can be triggered in two ways, one is to use transition keyword, another is to use event? HOT 7
- Can event be reused if it is not triggered the first time? HOT 4
- Add `actionMode` property to Parallel State and ForEach State HOT 5
- Update Apache EventMesh links HOT 4
- what's the difference between ${ { } }and ${} ? HOT 2
- CNCF TOC annual review due HOT 1
- Refactor error HOT 3
- Add means to throw an error HOT 24
- Refactor retries HOT 3
- CNCF TOC annual review due HOT 5
- Is Operation state with empty actions array valid? HOT 6
- Add parallel (and mixed) operations and events HOT 1
- Code of Conduct update to replace mediator email with the CNCF committee email HOT 1
- Unable to unmarshal FunctionRef.Invoke field HOT 2
- Is the specification so complex that it can be used in practice HOT 2
- String concatenation in JQ expression HOT 1
- Events and event correlation question HOT 2
- Bug in `functions` schema HOT 14
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from specification.