Coder Social home page Coder Social logo

Comments (7)

tsurdilo avatar tsurdilo commented on July 29, 2024

@jorgenj Thanks for the question! maxAttempts can limit the number of attempts when interval defines an unbounded number of repetitions , for example R/PT15M. In the param description the example is indeed somewhat confusing so I will update that asap.
Using maxAttempts even if interval is bounded could be useful in testing for example.

I am currently revising the error handling / timeouts / retries sections and will definitely include this as well as many more clarifications in the docs.

from specification.

jorgenj avatar jorgenj commented on July 29, 2024

I can't tell if there's a reason why I might use interval field to limit retries over using the separate maxAttempts attribute, perhaps some guidance on when/why a user might use one vs. the other would be helpful to add to the docs?

One advantage I see over the separate fields is it's a nice succinct way to define a basic retry policy (retry 5 times with 2 minutes in between -> "R5/2M").

On the other hand, the concern is that this might get confusing when combined with functionality like progressive backoff. For example:

{ "interval": "R5/PT15M",
"multiplier": "1M"
}

At first glance, it's not clear whether this will have 15M between every retry, or follow an increasing series of backoffs (I personally would assume the progressive series (15m, 16m, 17m, ...)).

from specification.

tsurdilo avatar tsurdilo commented on July 29, 2024

@jorgenj all good points I am using your ideas atm as part of the workflow error docs updates. Will ping you to review PRs that have updates asap.

from specification.

tsurdilo avatar tsurdilo commented on July 29, 2024

@jorgenj i have taken the first step on this with just a small change interval/delay in PR #175.

Once that pr is merged we can move forward on the overall retry definition improvements.

from specification.

jorgenj avatar jorgenj commented on July 29, 2024

@tsurdilo I'm new to github issues, is it reasonable to assign this task to me? I'm not sure how to do that, is that something you can do?

from specification.

tsurdilo avatar tsurdilo commented on July 29, 2024

@jorgenj done

from specification.

github-actions avatar github-actions commented on July 29, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from specification.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.