[Feature request] Add WSD Support about samba

[MarvAmBass]

@shadowKing001 I just pushed a version which contains wsdd2 (the non python c implementation)
could you please check if it works as you expect it :)

thanks

you can also just close if the feature is successfully implemented

[MarvAmBass]

Hi,

wow I didn't know that windows no longer supports zeroconf - but thanks for the hint, I'll take a look into wsdd and evaluate how to integrate it into the samba container (maybe I'll create a small extra micro service container to be placed in the docker-compose.yml besides your samba - but I need to figure out how this works)

Also thanks for using my container :)

[MarvAmBass]

found a c implementation of wsdd -> https://github.com/Netgear/wsdd2

[shad-lp]

Works like a charm, you're really fast and efficient !
FYI, the name of the device in Windows discovery is the hostname of the container.
In your documentation, you are going for network_mode: host, so it's obviously the hostname of the host.
In my setup, I'm using a macvlan network, because of the NAS has already his own implementation of Samba, therefore I can avoid port conflict. So basically, if I don't set a hostname for the container, I'll get some random string of characters and numbers instead.

It could be useful to have a quick word about it in your documentation.
Feel free to ask for any further test you would like to conduct.

[MarvAmBass]

Hi @shadowKing001 thanks for you input, I just checked with my recommended setup -> I use the host network and it uses the docker hosts hostname for wsdd2.
You're right you should configure a container name, if you don't want the cryptic default generated container hostname