Coder Social home page Coder Social logo

Comments (3)

serjoscha87 avatar serjoscha87 commented on May 30, 2024

Glad you like it.

I'm currently short on time (again), but I will try to look into it the other day.

I guess I wrote this plugin as cockpit did not even support directories for assets. Guess that may be the reason for your issue.

Perhaps its something simple - hope I manage to look into it the upcoming two weeks.

But if you don't have the time to wait, you maybe want to ask in the cockpit discourse: https://discourse.getcockpit.com

there are a couple of guys who are really familar with the cockpit source and who are maybe able to immediately find out where the issue comes from

from cockpit_groupboundassets.

eXaminator avatar eXaminator commented on May 30, 2024

Hi @serjoscha87,

thanks for the answer. Maybe I'll find some time and dive into the plugin and how directories work and see what I can figure out.

I think that the directory structure might even be useful for this addon. Maybe it would be good to have a directory per group and group members have only access to that directory (and their subdirectories)? This would remove the need to "filter" the asset list as I suppose it works right now. That would also allow for the following possibilities:

  • Admins (or users without a group) have access to all assets
  • Admins can upload new assets into group specific directories with the group members having access to that asset
  • Admins can easily move assets from one group to another
  • Admins can upload assets into root / other directories without granting a group access to that asset

What do you think?

from cockpit_groupboundassets.

eXaminator avatar eXaminator commented on May 30, 2024

Ok, so I have been tinkering a bit with my idea above and though some of it seems a bit "dirty" as Cockpit doesn't seem to expose any events for asset folder stuff, it seems to work pretty well right now. I'll create a PR later today for you to have a look at it and see if you like what I have come up with. Though, to be fair, I changed most of the code I think (as it wasn't much code to begin with).

from cockpit_groupboundassets.

Related Issues (2)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.