Coder Social home page Coder Social logo

Comments (6)

nblumhardt avatar nblumhardt commented on September 28, 2024

That's interesting - thanks for the info.

For file output this makes sense; for other back-ends having properties like RequestId at the top level is a more useful.

There's nothing to prevent us having both: pushing the scope object onto the stack and decomposing it, so you'd get:

2017-02-15 15:28:34 [Information] [{RequestId: "0HL2LV9E249UM", RequestPath: "/"}, "Main", "Main2"] Waiting for user input

(Or something pretty similar, if we use the formatter to convert the value into its string form.)

The down-side would be the extra weight in the Scope payload, duplicating info we've already attached to the event. In some situations I can see this making a pretty substantial impact on event size, it's not unusual to have quite a lot of scope data:

image

Not all properties above are coming in via BeginScope(), but a lot are (ActionId, ActionName, ...) and I don't know how usable this would be when rendered out into a log file. Serilog.Extensions.Logging.File gets around this by picking a few key properties like RequestId and giving them special treatment.

The current scheme manages to preserve all of the available information fairly efficiently. FWIW, I wrote up the scheme we're using a little while ago - https://nblumhardt.com/2016/11/ilogger-beginscope/ - I don't think there's much more detail in that post than you already have, though.

Thoughts?

from serilog-extensions-logging.

pakrym avatar pakrym commented on September 28, 2024

@nblumhardt what if we only add .ToString() representation of scope value to Scope property?

from serilog-extensions-logging.

nblumhardt avatar nblumhardt commented on September 28, 2024

@pakrym I don't think it would make much difference - the text wo

from serilog-extensions-logging.

nblumhardt avatar nblumhardt commented on September 28, 2024

(Keyboard fumble..)

The text would still be long, and the amount of data attached to the event would be similar. That ActionName property for example would still push the rest of the event information far out into the right column.

How does the console provider end up looking when scope gets heavy use? Is it still readable? I haven't had any experience with the built-in providers yet, personally.

from serilog-extensions-logging.

nblumhardt avatar nblumhardt commented on September 28, 2024

Now that it's possible to include {Properties} in Serilog console output templates, I think this is a reasonable alternative to including everything in the rendering of {Scope}; although it's a strong suggestion, I don't think we're likely to tackle this in the near future. Thanks @pakrym !

from serilog-extensions-logging.

wzuqui avatar wzuqui commented on September 28, 2024

In my case, I had to make a easy.

Here's the code on github:
https://github.com/wzuqui/Serilog.Enrichers.ActionName/blob/master/ActionName.cs

from serilog-extensions-logging.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.