serde support in the 4.0.x line about serialport-rs

[fpagliughi]

Nice! Thanks. No worries about the response time; this week I merged a 3 year old PR into one of my project. It was so old that the author had deleted his branch and likely retired from his job.

I think this kind of thing (older compilers) will become more common as Rust becomes more popular and corporate. On this job, we need four different developer groups to approve an update to the compiler!

[fpagliughi]

Alternately reconsider the version = 2021 requirement.

The library itself seems to compile fine with rustc v1.46.0. The tests seem to use some newer features, going up to around v.154.0 (version 2018).

Considering this library is especially useful in Embedded Linux contexts, it would be really nice to keep the MSRV as old as reasonably possible without making things painful for yourselves. But certainly don't constrain it by artificially specifying a later version than is necessary.

By just changing the version in Cargo.toml, it works for me with the latest Yocto:

edition = "2018"
#rust-version = "1.54"

[jessebraham]

Thanks for this issue! Sorry for taking so long to get around to replying and for breaking compatibility, I didn't realize such relatively old versions of Rust were still commonly used 😁

I've reverted to the 2018 edition locally and fixed any clippy/other issues, so I will get that pushed and merged. I also plan to publish a new release of this library soon (this or next week) which will include these changes, so you should be able to use this newest version moving forward.

[jessebraham]

I released 4.2.0 today which is now edition 2018 again, and includes the serde PR.

[fpagliughi]

Nice! Thanks.