Lack of verbosity during AttributeErrors about deepface

[0phoi5]

The relevant section of code that needs amendment is in ~/.local/lib/python3.10/site-packages/deepface/commons/functions.py;

# img might be path, base64 or numpy array. Convert it to numpy whatever it is.
    img, img_name = load_image(img)
    img_region = [0, 0, img.shape[1], img.shape[0]]

    if detector_backend == "skip":
        face_objs = [(img, img_region, 0)]
    else:
        face_objs = DetectorWrapper.detect_faces(detector_backend, img, align)

[0phoi5]

Possibly not the perfect solution, but this works well enough.
{img_name} needs to be printed at the point of failure. I used a try/except, one can then see what image failed to read correctly and simply remove it from the input directory or fix the image itself.

    # img might be path, base64 or numpy array. Convert it to numpy whatever it is.
    try:
        img, img_name = load_image(img)
        img_region = [0, 0, img.shape[1], img.shape[0]]

        if detector_backend == "skip":
            face_objs = [(img, img_region, 0)]
        else:
            face_objs = DetectorWrapper.detect_faces(detector_backend, img, align)
    except AttributeError as e:
        raise ValueError(f"Unreadable file - AttributeError occured for {img_name}: {e}")

ValueError: Unreadable file - AttributeError occured for /path/to/dir/failed_image.jpg: 'NoneType' object has no attribute 'shape'

[serengil]

Definitely, users should see a meaningful exception message.

Firstly, as I see you are using an old version of DeepFace. Would you please update the package first? This may not be an issue for the current package.

Instead of using try catch, I prefer to raise an error if img is None after load_image performed: https://github.com/serengil/deepface/blob/master/deepface/modules/detection.py#L77

[serengil]

Closed with PR - #1038